New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove htmllint. #27603

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
3 participants
@XhmikosR
Member

XhmikosR commented Nov 5, 2018

Rationale:

  1. We use the official HTML validator for HTML validation, and we don't really use any of the htmllint features.
  2. Everything runs on CI so we are covered in the case one of the devs doesn't have Java installed
Remove htmllint.
We use the official HTML validator for HTML validation, and we don't really use any of the htmllint features.
@mdo

mdo approved these changes Nov 5, 2018

@XhmikosR XhmikosR merged commit e3abb8e into v4-dev Nov 5, 2018

5 checks passed

bundlesize Good job! bundle size < maxSize
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.966%
Details
deploy/netlify Deploy preview ready!
Details

@XhmikosR XhmikosR deleted the v4-dev-xmr-rm-htmllint branch Nov 5, 2018

@mdo mdo referenced this pull request Nov 5, 2018

Open

v4.2.0 shiplist #26952

@XhmikosR XhmikosR added this to Inbox in v4.2 via automation Nov 5, 2018

@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.2 Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment