Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bump supported browsers for v5 #28317

Merged
merged 4 commits into from May 3, 2019
Merged

[WIP] Bump supported browsers for v5 #28317

merged 4 commits into from May 3, 2019

Conversation

@mdo
Copy link
Member

mdo commented Feb 19, 2019

WIP while we discuss, but wanted to use the PR to get the conversation going.

Fixes #28310

@mdo mdo added build v5 labels Feb 19, 2019
@mdo mdo added this to Inbox in v5 via automation Feb 19, 2019
Safari >= 9
Android >= 4.4
Opera >= 30
Chrome >= 70

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Feb 20, 2019

Member

I wouldn't go there. IIRC the Google search bot is based on Chrome 47/48 or something like that. I need to find the source for this though.

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Feb 22, 2019

Member

Found it: https://developers.google.com/search/docs/guides/rendering

Googlebot uses a web rendering service (WRS) that is based on Chrome 41 (M41)

Maybe by the time v5 stable is out this has changed, but until then, we shouldn't do this.

On the other hand we already use v45 here...

This comment has been minimized.

Copy link
@tkrotoff

tkrotoff Jun 18, 2019

Contributor

FYI "The new evergreen Googlebot [...] now runs the latest Chromium rendering engine (74 at the time of this post) [...] Moving forward, Googlebot will regularly update its rendering engine"

Source: https://webmasters.googleblog.com/2019/05/the-new-evergreen-googlebot.html

And https://developers.google.com/search/docs/guides/fix-search-javascript does not specify anymore the Chrome version used by Googlebot

.browserslistrc Show resolved Hide resolved
@XhmikosR XhmikosR changed the title Bump supported browsers for v5 [WIP] Bump supported browsers for v5 Feb 20, 2019
iOS >= 10
Safari >= 10
Android >= 5
Opera >= 50

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Feb 20, 2019

Member

I don't know if we should have Opera here at all. Opera is a Chromium based browser now.

This comment has been minimized.

Copy link
@mdo

mdo Feb 21, 2019

Author Member

I think it's fine to be explicit though? Each browser has different functionality that comes with major versions, so we might want to review some of the milestones there to ensure we're not shooting ourselves in the foot.

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Feb 22, 2019

Member

Yes, but why make an exception for Opera? I mean, we don't do the same for the other Chromium-based browsers.

BTW just thinking out loud here.

@XhmikosR

This comment has been minimized.

.browserslistrc Outdated Show resolved Hide resolved
@XhmikosR XhmikosR force-pushed the v5-browserslist branch from 1355f1f to c9537ff Feb 22, 2019
@thecodingdude

This comment has been minimized.

Copy link

thecodingdude commented Feb 26, 2019

Is IE11 being kept around? Issue #28349 removes some IE leftovers but there's queries as to whether Bootstrap should work at all in IE11.

Personally, it'd be easier to keep V4 for IE11 and use V5 (and beyond) to target more modern browsers. Now jQuery is being dropped it's possible to look into ESM (and maybe the JS can be shipped without being transpiled) but with IE11 that won't be possible.

@voltaek

This comment has been minimized.

Copy link

voltaek commented Feb 26, 2019

The issue with keeping v4 for IE11 is it also supports IE10. I'm hoping to see v5 work decent enough on IE11 with the recommended polyfills that I'll be able to justify moving to it instead of having to stick with v4 for the foreseeable future.

@XhmikosR XhmikosR mentioned this pull request Feb 27, 2019
19 of 22 tasks complete
@XhmikosR XhmikosR force-pushed the v5-browserslist branch 2 times, most recently from cf09acd to 05bf585 Mar 1, 2019
@mdo mdo mentioned this pull request Mar 13, 2019
13 of 13 tasks complete
@XhmikosR XhmikosR force-pushed the v5-browserslist branch from a79f16e to c5eb9a3 Mar 13, 2019
@XhmikosR XhmikosR force-pushed the v5-browserslist branch from 1b1a5a6 to 14eb6ac Mar 18, 2019
@XhmikosR XhmikosR force-pushed the v5-browserslist branch from 14eb6ac to db7c050 Mar 18, 2019
XhmikosR and others added 2 commits May 3, 2019
Still WIP, but wanting to get this merged, so finding a slightly wider baseline
@mdo mdo merged commit a2594e1 into master May 3, 2019
5 checks passed
5 checks passed
bundlesize Good job! bundle size < maxSize
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.998%
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Inbox to Shipped May 3, 2019
@XhmikosR XhmikosR deleted the v5-browserslist branch May 3, 2019
@sebaherrera

This comment has been minimized.

Copy link

sebaherrera commented Jun 30, 2019

Hi. Since Android 5, Webview is available at its own apk (based in Chromium 75.0.3770.101 as of today), so it will be useful to support that OS version as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
8 participants
You can’t perform that action at this time.