New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
move util in a util folder with the sanitizer #28345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
force-pushed
the
v5-dev-jo-util
branch
from
February 22, 2019 22:46
b9b652f
to
5d5b37d
Compare
Johann-S
commented
Feb 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it generate a strange issue when you hide a collapse 馃
https://deploy-preview-28345--twbs-bootstrap.netlify.com/docs/4.3/components/collapse/#multiple-targets
XhmikosR
reviewed
Feb 23, 2019
XhmikosR
changed the title
move util in a util folder with the sanitizer
[WIP] move util in a util folder with the sanitizer
Feb 23, 2019
Johann-S
force-pushed
the
v5-dev-jo-util
branch
from
February 24, 2019 10:32
5d5b37d
to
0e87e5f
Compare
I fixed the collapse plugin 馃憤 |
Johann-S
force-pushed
the
v5-dev-jo-util
branch
3 times, most recently
from
February 24, 2019 10:50
adecf28
to
bf7f128
Compare
Johann-S
changed the title
[WIP] move util in a util folder with the sanitizer
move util in a util folder with the sanitizer
Feb 24, 2019
XhmikosR
force-pushed
the
v5-dev-jo-util
branch
2 times, most recently
from
February 24, 2019 14:17
c7030e6
to
189399a
Compare
Johann-S
force-pushed
the
v5-dev-jo-util
branch
from
February 24, 2019 21:26
189399a
to
b8a7647
Compare
XhmikosR
force-pushed
the
v5-dev-jo-util
branch
7 times, most recently
from
February 26, 2019 07:40
4e65187
to
2bd8563
Compare
Johann-S
force-pushed
the
v5-dev-jo-util
branch
from
February 26, 2019 10:58
2bd8563
to
e968dc3
Compare
XhmikosR
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope @XhmikosR won't be angry against me but... I like to break everything and it's just the beginning 馃槇