Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 dev backports #29177

merged 13 commits into from Aug 17, 2019


Copy link

commented Jul 31, 2019

No description provided.

@XhmikosR XhmikosR added the v4 label Jul 31, 2019

@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 4 times, most recently from b4f43eb to 64b4afb Aug 3, 2019

@XhmikosR XhmikosR marked this pull request as ready for review Aug 6, 2019

@XhmikosR XhmikosR requested a review from twbs/css-review as a code owner Aug 6, 2019

@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 3 times, most recently from 61bcb6d to a3102f2 Aug 6, 2019

mdo and others added 8 commits Jul 22, 2019
v4/v5: Add responsive containers (#29095)
* create responsive containers

provide more flexibility and allow the user to determine when containers switch from fluid to fixed width.

* fix the base container code

this commit fixes the non-media portion of the generated CSS. I learned about the `@extends` directive and was able to put it to good use.

I create a new temporary map that contains all the main `$container-max-widths` and join it to our 2 special cases of 'xs' and 'fluid'.  Then we loop through that and, with the appropriate infixes, extend our placeholder

* formatting for style

forgot to run my tests before the last push, i think these are better.

* finish incomplete comment

* fix the responsive containers

using the `@extend` directive I was able to clean up this code

* fix responsive containers in the navbar

mostly we just look through all of our breakpoints so we can include all of the responsive container classes in the tweaks we have to do for the navbar (redeclaring flex properties, don't double up on padding, etc)

* Simplify container extends

* Simplify navbar containers

* Rearrange, add comments, ensure everything is nested in $enable-grid-classes

* Reduce new CSS by using attribute selector

We avoid using `@extend` whenever possible, and this is more readable

* Update _grid.scss

* Update _navbar.scss

* Add docs for responsive containers, redesign the container layout page

* Add to the Grid example
Responsive containers (follow-up to #29095) (#29118)
* Follow-up to #29095

This PR fixes the responsive containers that were added in #29095, originally stubbed out in #25631. Apologies to @browner12 for getting that wrong.

Fixes #25631.

* update navbar as well because we cannot reset all containers uniformly

* Update navbars example to include container-xl example to ensure containers match

* rewrite responsive containers docs, add table of max-widths

* Update container docs
- Move table up to the intro
- Remove the container example because it's actually hella confusing
- Update and link to grid example as a demo instead

@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 5 times, most recently from b02cfa9 to 0662c52 Aug 10, 2019

mdo approved these changes Aug 15, 2019

@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch from 0662c52 to ec8a4a7 Aug 16, 2019

@XhmikosR XhmikosR merged commit 9519b9e into v4-dev Aug 17, 2019

8 of 9 checks passed

Node 6
Node 6
Node 8
Node 8
Node 12
Node 12
coverage/coveralls Coverage decreased (-2.8%) to 91.491%
bundlesize Total bundle size is 172.63KB/174.75KB (-null)
deploy/netlify Deploy preview ready!

@XhmikosR XhmikosR deleted the v4-dev-xmr branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.