Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function map-get-multiple now returns the correct variable (#29246) #29247

Merged
merged 3 commits into from Aug 13, 2019

Conversation

@devdot
Copy link
Contributor

devdot commented Aug 13, 2019

Simple fix for a simple issue. The return value of map-get-multiple in scss/_functions.scss was wrong. The function didn't do anything.

Fixes #29246

@devdot devdot requested a review from twbs/css-review as a code owner Aug 13, 2019
devdot and others added 2 commits Aug 13, 2019
Copy link
Member

MartijnCuppens left a comment

Nice catch, thanks! I've also decreased the bundlesizes of the grid CSS, now that less CSS is generated.

@XhmikosR XhmikosR added css v5 labels Aug 13, 2019
@XhmikosR XhmikosR added this to Inbox in v5 via automation Aug 13, 2019
@XhmikosR XhmikosR merged commit 7149b6f into twbs:master Aug 13, 2019
13 checks passed
13 checks passed
Node 8
Details
Node 8
Details
Node 8
Details
Node 8
Details
Node 10
Details
Node 10
Details
Node 10
Details
Node 10
Details
Node 12
Details
Node 12
Details
Node 12
Details
Node 12
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Inbox to Shipped Aug 13, 2019
@devdot devdot deleted the devdot:fix-map-get-multiple branch Aug 14, 2019
lucanos added a commit to lucanos/bootstrap that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
3 participants
You can’t perform that action at this time.