Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge lint scripts #29329

Merged
merged 3 commits into from Aug 30, 2019
Merged

Merge lint scripts #29329

merged 3 commits into from Aug 30, 2019

Conversation

@XhmikosR
Copy link
Member

XhmikosR commented Aug 29, 2019

It seems ESLint is faster for me this way, stylelint is slower though.

Note that you should remove the .cache directory prior to making any tests.

/CC @twbs/team

@XhmikosR XhmikosR added build v5 labels Aug 29, 2019
@XhmikosR XhmikosR force-pushed the master-xmr-merge-lint-scripts branch from f02cb23 to 198bb84 Aug 29, 2019
@MartijnCuppens

This comment has been minimized.

Copy link
Member

MartijnCuppens commented Aug 29, 2019

I'm ok with this. Personally I would prefer \"**/*.{css,scss}\" (not sure if the curly brackets need to be escaped) instead of \"**/*.scss\" \"**/*.css\"

@XhmikosR XhmikosR force-pushed the master-xmr-merge-lint-scripts branch from 198bb84 to 69e4709 Aug 30, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member Author

XhmikosR commented Aug 30, 2019

Merged those, good call.

@XhmikosR XhmikosR marked this pull request as ready for review Aug 30, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member Author

XhmikosR commented Aug 30, 2019

@Johann-S can you try this too?

@Johann-S

This comment has been minimized.

Copy link
Member

Johann-S commented Aug 30, 2019

It works well for me too 👍

@XhmikosR XhmikosR merged commit a6460d9 into master Aug 30, 2019
9 checks passed
9 checks passed
Node 8
Details
Node 8
Details
Node 10
Details
Node 10
Details
Node 12
Details
Node 12
Details
bundlesize Total bundle size is 235.1KB/248KB (-null)
Details
coverage/coveralls Coverage decreased (-0.1%) to 94.179%
Details
deploy/netlify Deploy preview ready!
Details
@XhmikosR XhmikosR deleted the master-xmr-merge-lint-scripts branch Aug 30, 2019
@XhmikosR XhmikosR added this to Inbox in v5 via automation Aug 30, 2019
@XhmikosR XhmikosR moved this from Inbox to Shipped in v5 Aug 30, 2019
lucanos added a commit to lucanos/bootstrap that referenced this pull request Oct 27, 2019
* Merge js-lint scripts into one script.

* Merge stylelint scripts into one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
3 participants
You can’t perform that action at this time.