Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "extra" section from composer.json #29420

Merged
merged 4 commits into from Oct 2, 2019
Merged

Conversation

@andreasschroth
Copy link
Contributor

andreasschroth commented Sep 18, 2019

This section is meaningless and doesn't serve any purpose.

To give some more context: The branch alias is good for mapping dev-master (which is the latest dev version of a project) to a specific development branch. But if your master branch is always the latest dev version (as it is the case with Bootstrap), no mapping is needed.

Only problem could be, if another package is requiring a specific version and that conflicts with dev-master (on the master) branch if there's no alias set. But I would say this is VERY unlikely with a project like Bootstrap.

See also https://getcomposer.org/doc/articles/aliases.md#branch-alias .

This section is meaningless and doesn't serve any purpose.
@XhmikosR XhmikosR added meta v5 labels Sep 20, 2019
@XhmikosR XhmikosR added this to Inbox in v5 via automation Sep 20, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Sep 20, 2019

In the past, i.e. when v4 was being developed, development happened on v4-dev and master was behind.

Do you think this could break things if we remove it?

@andreasschroth

This comment has been minimized.

Copy link
Contributor Author

andreasschroth commented Sep 21, 2019

No, unless someone would require another package that depends on the version being developed, e.g. 4.xAND it's added in the project as dev-master. But why would another package depend on an unreleased version...?

Basically this section only serves as a mapping and is only useful if other packages depend on specific versions being developed.

I would say it's absolutely safe to remove it.

v5 automation moved this from Inbox to Approved Sep 27, 2019
@mdo
mdo approved these changes Sep 27, 2019
XhmikosR added 3 commits Sep 28, 2019
@XhmikosR XhmikosR merged commit c306e96 into twbs:master Oct 2, 2019
5 checks passed
5 checks passed
Node 8
Details
Node 10
Details
Node 12
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Approved to Shipped Oct 2, 2019
@andreasschroth andreasschroth deleted the andreasschroth:patch-1 branch Oct 2, 2019
lucanos added a commit to lucanos/bootstrap that referenced this pull request Oct 27, 2019
This section is meaningless and doesn't serve any purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
3 participants
You can’t perform that action at this time.