Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim trailing whitespace from markdown files #29460

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Sep 28, 2019

We don't have trailing whitespaces for any markdown file. It's also quite annoying the trailing whitespaces aren't removed when writing documentation.

@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Sep 28, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Sep 29, 2019

LGTM but this is incomplete anyway, since we don't filter the allowed HTML elements (so as to allow <br> or not).

I need to check all markdown files just in case though.

@MartijnCuppens

This comment has been minimized.

Copy link
Member Author

MartijnCuppens commented Sep 29, 2019

I searched for occurrences of trailing whitespaces in our codebase and it only seems to be present in clipboard.min.js (opened webpack/webpack#9756 to tackle this issue upstream). The markdown files should be ok.

v5 automation moved this from Inbox to Approved Oct 2, 2019
@XhmikosR XhmikosR merged commit 494713b into master Oct 2, 2019
10 checks passed
10 checks passed
Node 8
Details
Node 8
Details
Node 10
Details
Node 10
Details
Node 12
Details
Node 12
Details
LGTM analysis: JavaScript No code changes detected
Details
bundlesize Total bundle size is 235.78KB/248KB (-null)
Details
coverage/coveralls First build on refs/heads/master-mc-remove-markdown-whitespace at 94.277%
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Approved to Shipped Oct 2, 2019
@XhmikosR XhmikosR deleted the master-mc-remove-markdown-whitespace branch Oct 2, 2019
lucanos added a commit to lucanos/bootstrap that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
2 participants
You can’t perform that action at this time.