Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the Coveralls Action #29478

Merged
merged 7 commits into from Nov 18, 2019
Merged

Switch to the Coveralls Action #29478

merged 7 commits into from Nov 18, 2019

Conversation

@XhmikosR
Copy link
Member

XhmikosR commented Oct 2, 2019

This is the official way of using Coveralls with Actions. Also this brings back Coveralls for PRs.

Requires #29458 to be merged.

Fixes #29457

@XhmikosR XhmikosR added this to Inbox in v5 via automation Oct 2, 2019
@XhmikosR XhmikosR added this to Inbox in v4.4.0 via automation Oct 2, 2019
@XhmikosR XhmikosR force-pushed the master-xmr-cov-action-2 branch 2 times, most recently from 3a51e86 to 217ed68 Oct 2, 2019
@XhmikosR XhmikosR marked this pull request as ready for review Oct 2, 2019
@mdo

This comment has been minimized.

Copy link
Member

mdo commented Oct 3, 2019

  • Remove the repo secret (COVERALLS_REPO_TOKEN ) before merging this

Will that break the new integration? If not, let's keep tests from failing and remove afterwards maybe?

@XhmikosR

This comment has been minimized.

Copy link
Member Author

XhmikosR commented Oct 3, 2019

This will only break for PRs or branches that might still use the old way. For master we won't have any problem. For v4-dev, I will cherry pick it in #29482 after this PR is merged.

@XhmikosR XhmikosR force-pushed the master-xmr-cov-action-2 branch from e0caac3 to 3bf5aaf Oct 4, 2019
@XhmikosR XhmikosR requested a review from mdo Oct 4, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member Author

XhmikosR commented Oct 4, 2019

We are also getting rid of one devDependency BTW.

@XhmikosR

This comment was marked as outdated.

Copy link
Member Author

XhmikosR commented Oct 7, 2019

There's currently a bug which I really hope gets fixed soon because we end up with comments on PRs.

I've already switched to this action in a few of my other projects, it works well apart from the aforementioned issue.

I guess we can live for a while with a few comments until this gets fixed?

@XhmikosR XhmikosR force-pushed the master-xmr-cov-action-2 branch 2 times, most recently from 3754c7f to fae7cd0 Oct 7, 2019
@XhmikosR

This comment was marked as outdated.

Copy link
Member Author

XhmikosR commented Oct 15, 2019

@mdo I really want to move forward with this. Can you get someone from GH to look into helping upstream to solve the extra comments issue coverallsapp/github-action#5?

@XhmikosR XhmikosR force-pushed the master-xmr-cov-action-2 branch from 573415d to b47560b Oct 15, 2019
@XhmikosR XhmikosR added the on-hold label Oct 25, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member Author

XhmikosR commented Oct 25, 2019

This is blocked until the extra comments issue is solved

@XhmikosR XhmikosR removed this from Inbox in v4.4.0 Oct 25, 2019
@XhmikosR XhmikosR force-pushed the master-xmr-cov-action-2 branch 2 times, most recently from e471868 to b84f7b2 Nov 4, 2019
This is the official way of using Coveralls with Actions. Also this brings back Coveralls for PRs.
@XhmikosR XhmikosR force-pushed the master-xmr-cov-action-2 branch from b84f7b2 to 1380a95 Nov 7, 2019
@XhmikosR XhmikosR requested review from Johann-S and MartijnCuppens Nov 14, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member Author

XhmikosR commented Nov 14, 2019

The comments issue seems fixed so it should be OK to switch to this.

@XhmikosR XhmikosR added this to Inbox in v4.4.0 via automation Nov 14, 2019
@XhmikosR XhmikosR removed the on-hold label Nov 14, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member Author

XhmikosR commented Nov 14, 2019

@mdo you can remove the COVERALLS_REPO_TOKEN secret.

XhmikosR added 3 commits Nov 15, 2019
v5 automation moved this from Inbox to Approved Nov 18, 2019
@XhmikosR XhmikosR merged commit 099860d into master Nov 18, 2019
8 checks passed
8 checks passed
Node 10
Details
Node 10
Details
Node 12
Details
Node 12
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
bundlesize Total bundle size is 236.24KB/248KB (-null)
Details
coverage/coveralls First build on master-xmr-cov-action-2 at 94.185%
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Approved to Shipped Nov 18, 2019
@XhmikosR XhmikosR deleted the master-xmr-cov-action-2 branch Nov 18, 2019
XhmikosR added a commit that referenced this pull request Nov 18, 2019
This is the official way of using Coveralls with Actions. Also this brings back Coveralls for PRs.
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.4.0 Nov 25, 2019
XhmikosR added a commit that referenced this pull request Nov 25, 2019
This is the official way of using Coveralls with Actions. Also this brings back Coveralls for PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
v4.4.0
  
Shipped
3 participants
You can’t perform that action at this time.