Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double quotes in `.stylelintrc` #29709

Merged
merged 1 commit into from Nov 22, 2019
Merged

Conversation

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Nov 22, 2019

This rule should also be backported in v4-dev. Shall we do a new PR or cherry-pick #29612 and this PR, @XhmikosR?

@MartijnCuppens MartijnCuppens requested a review from XhmikosR Nov 22, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Nov 22, 2019

We just need to cherry pick the quotes change if it applies on the current v4-dev. Newer stylelint-config-twbs-bootstrap versions don't work with Node.js 6.

@XhmikosR XhmikosR added this to Inbox in v5 via automation Nov 22, 2019
v5 automation moved this from Inbox to Approved Nov 22, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Nov 22, 2019

AFAICT there's nothing to backport in v4, so we are good.

@XhmikosR XhmikosR merged commit a65d066 into master Nov 22, 2019
8 checks passed
8 checks passed
Node 10
Details
Node 10
Details
Node 12
Details
Node 12
Details
LGTM analysis: JavaScript No code changes detected
Details
bundlesize Total bundle size is 236.24KB/248KB (-null)
Details
coverage/coveralls First build on master-mc-stylelintrc-double-quotes at 94.185%
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Approved to Shipped Nov 22, 2019
@XhmikosR XhmikosR deleted the master-mc-stylelintrc-double-quotes branch Nov 22, 2019
@MartijnCuppens

This comment has been minimized.

Copy link
Member Author

MartijnCuppens commented Nov 22, 2019

Newer stylelint-config-twbs-bootstrap versions don't work with Node.js 6.

Ow yeah, I forgot. looks good indeed then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
2 participants
You can’t perform that action at this time.