Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit flex-wrap to decrease generated css #29951

Merged
merged 2 commits into from Jan 7, 2020

Conversation

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Jan 3, 2020

The containers within the navbar are extended, which generates quite a lot of CSS. By inheriting the flex-wrap property, we avoid the generation of these styles.

Also added the child combinator to the containers and used flex-wrap instead of flex-flow, since the flex-direction shouldn't be set.

@MartijnCuppens MartijnCuppens requested a review from twbs/css-review as a code owner Jan 3, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Jan 3, 2020
v5 automation moved this from Inbox to Approved Jan 7, 2020
@mdo
mdo approved these changes Jan 7, 2020
@XhmikosR XhmikosR merged commit 6904afe into master Jan 7, 2020
8 checks passed
8 checks passed
Node 10
Details
Node 10
Details
Node 12
Details
Node 12
Details
LGTM analysis: JavaScript No code changes detected
Details
bundlesize Total bundle size is 235.75KB/248KB (-null)
Details
coverage/coveralls Coverage decreased (-0.03%) to 94.118%
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Approved to Shipped Jan 7, 2020
@XhmikosR XhmikosR deleted the master-mc-navbar-container-inherit-flex-wrap branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
3 participants
You can’t perform that action at this time.