Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo alignment for IE #29955

Merged
merged 1 commit into from Feb 14, 2020
Merged

Fix logo alignment for IE #29955

merged 1 commit into from Feb 14, 2020

Conversation

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Jan 5, 2020

The stack logo is misaligned in IE because IE doesn't handle height: auto all too well. With preserveAspectRatio we can align the SVG content within, which looks the same visually.

I also added a fix for newlines being added by IDEs each time an SVG is edited.

@MartijnCuppens MartijnCuppens requested a review from XhmikosR Jan 5, 2020
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Jan 5, 2020
@MartijnCuppens MartijnCuppens force-pushed the master-mc-fix-stack-ie branch from 33c0343 to 695f742 Jan 5, 2020
@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Jan 8, 2020

Can you try adding align-items-center to the parent row? IE shows the image shrunk and I believe it will look better this way as long as we can make IE behave.

From my quick testing the only way I found to make IE work is to add width and height in the CSS, but this might break responsive.

@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Jan 8, 2020

Oh, and the newlines patch shouldn't be in this branch nor in the repo IMO. Not all SVG files are minified completely.

@MartijnCuppens

This comment has been minimized.

Copy link
Member Author

MartijnCuppens commented Jan 8, 2020

Oh, and the newlines patch shouldn't be in this branch nor in the repo IMO. Not all SVG files are minified completely.

Webstorm (and probably other IDEs) automatically respects the .editorconfig and add a EOF newline on save. So whenever I want to edit the SVGs I need to temporary disable it.

Not all SVG files are minified completely.

Could be, but adding this won't do harm in any case.

@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Jan 8, 2020

Could be, but adding this won't do harm in any case.

True, but I'd rather have the newlines at the end for the files that are not completely minified. I can add a chomp or trim around the SVG includes in Hugo to remove any newlines anyway.

Either way this change does not belong in this branch.

@twbs twbs deleted a comment Jan 8, 2020
@ysds
ysds approved these changes Feb 14, 2020
Copy link
Member

ysds left a comment

LGTM in the case.

v5 automation moved this from Inbox to Approved Feb 14, 2020
@MartijnCuppens MartijnCuppens force-pushed the master-mc-fix-stack-ie branch from f861e93 to 705f1e7 Feb 14, 2020
@MartijnCuppens

This comment has been minimized.

Copy link
Member Author

MartijnCuppens commented Feb 14, 2020

Dropped the newlines patch

@MartijnCuppens MartijnCuppens merged commit 9aee717 into master Feb 14, 2020
8 checks passed
8 checks passed
Node 10
Details
Node 10
Details
Node 12
Details
Node 12
Details
LGTM analysis: JavaScript No code changes detected
Details
bundlesize Total bundle size is 236.25KB/248KB (-null)
Details
coverage/coveralls Coverage remained the same at 94.262%
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Approved to Shipped Feb 14, 2020
@MartijnCuppens MartijnCuppens deleted the master-mc-fix-stack-ie branch Feb 14, 2020
GeoSot added a commit to GeoSot/bootstrap that referenced this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.