Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary comma in 'All colors' #30010

Merged
merged 4 commits into from Jan 16, 2020
Merged

Remove unnecessary comma in 'All colors' #30010

merged 4 commits into from Jan 16, 2020

Conversation

@tywmick
Copy link
Contributor

tywmick commented Jan 13, 2020

(Using a comma between a subject and predicate)[https://en.wikipedia.org/wiki/Comma#Between_the_subject_and_predicate] is nonstandard.
@XhmikosR XhmikosR requested review from mdo and patrickhlauke Jan 13, 2020
@XhmikosR XhmikosR added the docs label Jan 13, 2020
@XhmikosR XhmikosR added the v5 label Jan 13, 2020
@XhmikosR XhmikosR added this to Inbox in v5 via automation Jan 13, 2020
@patrickhlauke

This comment has been minimized.

Copy link
Member

patrickhlauke commented Jan 13, 2020

urgh, that sentence is ugly for other reasons as well. Agree with removing the comma, but while we're here could also change it altogether to

All colors available in Bootstrap 5 are available as Sass variables and as a Sass map in `scss/_variables.scss`.

(and a Sass map > and as a Sass map, and removing that file at the end)

v5 automation moved this from Inbox to Approved Jan 13, 2020
@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Jan 13, 2020

@patrickhlauke you can just edit the file and make your changes or use the GitHub's suggestions feature :)

@mdo
mdo approved these changes Jan 15, 2020
XhmikosR added 2 commits Jan 16, 2020
@XhmikosR XhmikosR merged commit 430c16d into twbs:master Jan 16, 2020
4 checks passed
4 checks passed
Node 10
Details
Node 12
Details
LGTM analysis: JavaScript No code changes detected
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Approved to Shipped Jan 16, 2020
GeoSot added a commit to GeoSot/bootstrap that referenced this pull request Feb 5, 2020
* Remove unnecessary comma in 'All colors'

(Using a comma between a subject and predicate)[https://en.wikipedia.org/wiki/Comma#Between_the_subject_and_predicate] is nonstandard.

* Update theming.md

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.