Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated nuspec content files and icon #30148

Merged
merged 9 commits into from Feb 10, 2020

Conversation

@supergibbs
Copy link
Contributor

supergibbs commented Feb 8, 2020

Fixes #30045

@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Feb 9, 2020

Hey, @supergibbs. Since v5 isn't out yet, I don't think we should land this. That being said, if you fix the indentation and ping me we can land the other parts.

@supergibbs

This comment has been minimized.

Copy link
Contributor Author

supergibbs commented Feb 9, 2020

Oh ok, I thought master was now the v5 dev but I’ll revert it and we can update later. The version tag is required but isn’t used. The build script pulls it from package.json.

@supergibbs supergibbs force-pushed the supergibbs:updated-nuspec-contentFiles branch from 8f0c337 to 1ae37a9 Feb 9, 2020
@supergibbs

This comment has been minimized.

Copy link
Contributor Author

supergibbs commented Feb 10, 2020

@XhmikosR All fixed!

XhmikosR added 3 commits Feb 10, 2020
@XhmikosR XhmikosR added the meta label Feb 10, 2020
@XhmikosR XhmikosR added this to Inbox in v5 via automation Feb 10, 2020
@XhmikosR XhmikosR added the v5 label Feb 10, 2020
@XhmikosR XhmikosR merged commit a0811af into twbs:master Feb 10, 2020
4 checks passed
4 checks passed
Node 10
Details
Node 12
Details
LGTM analysis: JavaScript No code changes detected
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Inbox to Shipped Feb 10, 2020
XhmikosR added a commit that referenced this pull request Feb 10, 2020
* #30045 - Update nuspec for updated content type

* Update iconUrl (deprecated) to icon

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@supergibbs supergibbs deleted the supergibbs:updated-nuspec-contentFiles branch Feb 10, 2020
XhmikosR added a commit that referenced this pull request Feb 12, 2020
* #30045 - Update nuspec for updated content type

* Update iconUrl (deprecated) to icon

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Feb 16, 2020
* #30045 - Update nuspec for updated content type

* Update iconUrl (deprecated) to icon

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR added a commit that referenced this pull request Feb 17, 2020
* #30045 - Update nuspec for updated content type

* Update iconUrl (deprecated) to icon

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.