v5: Update system font stack #30561
Merged
v5: Update system font stack #30561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we drop |
Yup! You're right, thanks for the callout. Verified our browser support list and compared, it's safe to remove. |
MartijnCuppens
approved these changes
Apr 13, 2020
|
I'm likely out of my league here, but researching updating my font-stack I can across issues with system-ui as below. #22377 |
|
I think we’re in the clear but I don’t know for sure. We’ll find out in testing :). |
|
Just a headup: #22377 (i.e. https://infinnie.github.io/blog/2017/systemui.html) is still an issue on Chinese Windows. |
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
This was referenced Dec 12, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Dec 15, 2020
system-ui was added to the native font stack in #30561 but the docs were not updated.
This was referenced Apr 5, 2021
1 task
Matthewrbowker
pushed a commit
to phorgeit/phorge
that referenced
this pull request
Oct 9, 2022
Summary: `system-ui` is provided by modern browsers as [a cross-platform default font](https://caniuse.com/font-family-system-ui). Using this font [was a controversial choice back in 2017](https://infinnie.github.io/blog/2017/systemui.html). because it did not address i18n well and therefore it was removed from Bootstrap [twbs/bootstrap#22377](twbs/bootstrap#22377). However, it was added back in Bootstrap v5 [twbs/bootstrap#30561](twbs/bootstrap#30561) since it got better over time. Fixes T15049. Test Plan: Tested locally for now. Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: Matthew, avivey, Cigaryno, 20after4, Ekubischta, speck, tobiaswiese, valerio.bozzolan Maniphest Tasks: T15049 Differential Revision: https://we.phorge.it/D25021
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://codepen.io/emdeoh/pen/oNjgOPy.
caniuse.com data: https://caniuse.com/#feat=font-family-system-ui
Definitely needs more testing here, but latest Chrome and Safari support it, Firefox still needs
-apple-system, and legacy Edge/IE (not that we care) require explicit fonts later on.Fixes #25604.