Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type=radio] should always be rounded #30686

Merged
merged 4 commits into from Apr 29, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Apr 29, 2020

They're currently squared if $enable-rounded is set to false—which is IMHO bad for usability, and quite confusing for the end users.

@ffoodd ffoodd requested a review from a team as a code owner April 29, 2020 14:46
@MartijnCuppens
Copy link
Member

We could just use the property here instead.

@ffoodd
Copy link
Member Author

ffoodd commented Apr 29, 2020

Indeed, it'll be more robust if border-radius() mixin evolves in some way.

@ffoodd ffoodd force-pushed the master-fod-always-rounded-radio-buttons branch from 99704f1 to 9f70722 Compare April 29, 2020 14:53
@XhmikosR XhmikosR added this to Inbox in v5 via automation Apr 29, 2020
@XhmikosR XhmikosR merged commit 8bee113 into master Apr 29, 2020
v5 automation moved this from Inbox to Shipped Apr 29, 2020
@XhmikosR XhmikosR deleted the master-fod-always-rounded-radio-buttons branch April 29, 2020 18:13
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants