From 1a4d7f99b7d410965916ea8cd886a7bc233156d8 Mon Sep 17 00:00:00 2001 From: Siju Samson Date: Sat, 12 Dec 2020 15:35:03 +0530 Subject: [PATCH 1/7] Fix for popover example showing above navbar --- site/assets/scss/_subnav.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/assets/scss/_subnav.scss b/site/assets/scss/_subnav.scss index 8377ff4235e4..ae62101fce08 100644 --- a/site/assets/scss/_subnav.scss +++ b/site/assets/scss/_subnav.scss @@ -1,7 +1,7 @@ .bd-subnavbar { // The position and z-index are needed for the dropdown to stay on top of the content position: relative; - z-index: $zindex-sticky; + z-index: 1080; background-color: rgba($white, .95); box-shadow: 0 .5rem 1rem rgba(0, 0, 0, .05), inset 0 -1px 0 rgba(0, 0, 0, .15); From 2b1b1ca84c4c4ec0944b60eca8b49aec5a2b0541 Mon Sep 17 00:00:00 2001 From: Siju Samson Date: Tue, 15 Dec 2020 22:06:20 +0530 Subject: [PATCH 2/7] Added a variable for handling popover issue --- site/assets/scss/_subnav.scss | 2 +- site/assets/scss/_variables.scss | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/site/assets/scss/_subnav.scss b/site/assets/scss/_subnav.scss index ae62101fce08..8377ff4235e4 100644 --- a/site/assets/scss/_subnav.scss +++ b/site/assets/scss/_subnav.scss @@ -1,7 +1,7 @@ .bd-subnavbar { // The position and z-index are needed for the dropdown to stay on top of the content position: relative; - z-index: 1080; + z-index: $zindex-sticky; background-color: rgba($white, .95); box-shadow: 0 .5rem 1rem rgba(0, 0, 0, .05), inset 0 -1px 0 rgba(0, 0, 0, .15); diff --git a/site/assets/scss/_variables.scss b/site/assets/scss/_variables.scss index 110600260c2f..5e79f8719ea7 100644 --- a/site/assets/scss/_variables.scss +++ b/site/assets/scss/_variables.scss @@ -11,3 +11,4 @@ $bd-warning: #f0ad4e; $bd-danger: #d9534f; $dropdown-active-icon: url("data:image/svg+xml,"); $sidebar-collapse-icon: url("data:image/svg+xml,"); +$zindex-sticky: 1080; From 4e9022547519ff548e75870e6c7f0f16178cdea9 Mon Sep 17 00:00:00 2001 From: Siju Samson Date: Sat, 12 Dec 2020 15:35:03 +0530 Subject: [PATCH 3/7] Fix for popover example showing above navbar --- site/assets/scss/_subnav.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/assets/scss/_subnav.scss b/site/assets/scss/_subnav.scss index 8377ff4235e4..ae62101fce08 100644 --- a/site/assets/scss/_subnav.scss +++ b/site/assets/scss/_subnav.scss @@ -1,7 +1,7 @@ .bd-subnavbar { // The position and z-index are needed for the dropdown to stay on top of the content position: relative; - z-index: $zindex-sticky; + z-index: 1080; background-color: rgba($white, .95); box-shadow: 0 .5rem 1rem rgba(0, 0, 0, .05), inset 0 -1px 0 rgba(0, 0, 0, .15); From 608624a89e8e4a10efac91eed78592e2630277c6 Mon Sep 17 00:00:00 2001 From: Siju Samson Date: Tue, 15 Dec 2020 22:06:20 +0530 Subject: [PATCH 4/7] Added a variable for handling popover issue --- site/assets/scss/_subnav.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/assets/scss/_subnav.scss b/site/assets/scss/_subnav.scss index ae62101fce08..8377ff4235e4 100644 --- a/site/assets/scss/_subnav.scss +++ b/site/assets/scss/_subnav.scss @@ -1,7 +1,7 @@ .bd-subnavbar { // The position and z-index are needed for the dropdown to stay on top of the content position: relative; - z-index: 1080; + z-index: $zindex-sticky; background-color: rgba($white, .95); box-shadow: 0 .5rem 1rem rgba(0, 0, 0, .05), inset 0 -1px 0 rgba(0, 0, 0, .15); From 165088b19b3852c0c4316469992fa04519c9f2d2 Mon Sep 17 00:00:00 2001 From: Siju Samson Date: Tue, 15 Dec 2020 22:20:15 +0530 Subject: [PATCH 5/7] Changed variable name specifically to documentation. --- site/assets/scss/_subnav.scss | 2 +- site/assets/scss/_variables.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/site/assets/scss/_subnav.scss b/site/assets/scss/_subnav.scss index 8377ff4235e4..8979aa3cd2f7 100644 --- a/site/assets/scss/_subnav.scss +++ b/site/assets/scss/_subnav.scss @@ -1,7 +1,7 @@ .bd-subnavbar { // The position and z-index are needed for the dropdown to stay on top of the content position: relative; - z-index: $zindex-sticky; + z-index: $bd-navbar-zindex; background-color: rgba($white, .95); box-shadow: 0 .5rem 1rem rgba(0, 0, 0, .05), inset 0 -1px 0 rgba(0, 0, 0, .15); diff --git a/site/assets/scss/_variables.scss b/site/assets/scss/_variables.scss index 5e79f8719ea7..11f58db1f1d1 100644 --- a/site/assets/scss/_variables.scss +++ b/site/assets/scss/_variables.scss @@ -11,4 +11,4 @@ $bd-warning: #f0ad4e; $bd-danger: #d9534f; $dropdown-active-icon: url("data:image/svg+xml,"); $sidebar-collapse-icon: url("data:image/svg+xml,"); -$zindex-sticky: 1080; +$bd-navbar-zindex: 1080; From 70442d943357fcd81e238bd33db8cfc9746313e8 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Wed, 16 Dec 2020 08:43:29 +0200 Subject: [PATCH 6/7] Update _variables.scss --- site/assets/scss/_variables.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/assets/scss/_variables.scss b/site/assets/scss/_variables.scss index 11f58db1f1d1..c439b01ce70a 100644 --- a/site/assets/scss/_variables.scss +++ b/site/assets/scss/_variables.scss @@ -11,4 +11,4 @@ $bd-warning: #f0ad4e; $bd-danger: #d9534f; $dropdown-active-icon: url("data:image/svg+xml,"); $sidebar-collapse-icon: url("data:image/svg+xml,"); -$bd-navbar-zindex: 1080; +$bd-navbar-zindex: 1080; From c6b1c07a17dcb47e5b74d785ce85800c8dd83a13 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Wed, 16 Dec 2020 10:39:02 +0200 Subject: [PATCH 7/7] Update _variables.scss --- site/assets/scss/_variables.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/site/assets/scss/_variables.scss b/site/assets/scss/_variables.scss index c439b01ce70a..6e1ae2efd0d5 100644 --- a/site/assets/scss/_variables.scss +++ b/site/assets/scss/_variables.scss @@ -11,4 +11,6 @@ $bd-warning: #f0ad4e; $bd-danger: #d9534f; $dropdown-active-icon: url("data:image/svg+xml,"); $sidebar-collapse-icon: url("data:image/svg+xml,"); + +// Higher than core's $zindex-tooltip, which is 1070 $bd-navbar-zindex: 1080;