Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal when is triggered by bs-toggle, to hide other open instances #34701

Merged
merged 3 commits into from Aug 10, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Aug 6, 2021

Closes #34691 #34755

@GeoSot GeoSot requested a review from a team as a code owner August 6, 2021 08:10
@GeoSot GeoSot changed the title Fix modal when trigger by bs-toggle to hide other open instances Fix modal when is triggered by bs-toggle, to hide other open instances Aug 6, 2021
@GeoSot GeoSot force-pushed the gs/modal-toggle-should-close-other-instances branch from 70a5d10 to 6bed382 Compare August 6, 2021 08:11
@GeoSot GeoSot added this to In progress in v5.1.1 via automation Aug 6, 2021
v5.1.1 automation moved this from In progress to Reviewer approved Aug 10, 2021
@XhmikosR XhmikosR merged commit 1e5e655 into main Aug 10, 2021
v5.1.1 automation moved this from Reviewer approved to Done Aug 10, 2021
@XhmikosR XhmikosR deleted the gs/modal-toggle-should-close-other-instances branch August 10, 2021 14:55
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
@Sun3
Copy link

Sun3 commented Aug 27, 2021

I am using Bootstrap 5.1 and this issue is still happening. Is this fix being released in the next version?

Thank you.

js/src/modal.js Show resolved Hide resolved
js/src/modal.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.1.1
  
Done
Development

Successfully merging this pull request may close these issues.

Toggling between Modals does not work correctly. Toggle between modals has issue
4 participants