Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator for table direct children #34861

Merged
merged 8 commits into from Sep 9, 2021
Merged

Separator for table direct children #34861

merged 8 commits into from Sep 9, 2021

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Sep 1, 2021

Fixes #34732, closes #34764 as a replacement, basically refactoring the evolution from v4 instead of adding old code.

The main culprit here is getting back to a 2px border, since for whatever reason a 1px border is hidden behind cells borders. As pointed out by @adityadees, a 1.1 multiplicator would be enough, but feels like a magic number to me.

IMHO @mdo we'd better recommend to use our border utilities (eg. .border-dark in the initial issue, as in this dedicated CodePen) rather than fixing this. Any thought?


Demo on CodePen.

@ffoodd ffoodd marked this pull request as ready for review Sep 1, 2021
@ffoodd ffoodd requested a review from as a code owner Sep 1, 2021
@mdo mdo added this to In progress in v5.1.1 via automation Sep 1, 2021
@mdo
Copy link
Member

mdo commented Sep 1, 2021

I feel like the new code is actually simpler somehow? I don't mind it as the path forward. Utilities could work, but ideally stuff like this works out of the box IMO. Maybe I made tables too opinionated in v5 😬

@mdo mdo removed this from In progress in v5.1.1 Sep 1, 2021
@ffoodd
Copy link
Member Author

ffoodd commented Sep 2, 2021

So what about this 😄? Do we stick with the 2px border as in this PR, or do we move things again to support this?

@adityadees
Copy link

adityadees commented Sep 6, 2021

I feel like the new code is actually simpler somehow? I don't mind it as the path forward. Utilities could work, but ideally stuff like this works out of the box IMO. Maybe I made tables too opinionated in v5 😬

Nah, I think since v5 you reduce 2 to 1. But I don't know why?
That's why I just put 1.1 just to add second border bigger than first border without change initial value from v5.

@mdo mdo added this to In progress in v5.1.2 via automation Sep 7, 2021
mdo
mdo approved these changes Sep 8, 2021
Copy link
Member

@mdo mdo left a comment

@ffoodd I think we stick with the 2px still. Let's ship it!

v5.1.2 automation moved this from In progress to Ready to merge Sep 8, 2021
@XhmikosR XhmikosR merged commit 2a925d6 into main Sep 9, 2021
27 checks passed
v5.1.2 automation moved this from Ready to merge to Done Sep 9, 2021
@XhmikosR XhmikosR deleted the main-fod-table-children branch Sep 9, 2021
chappjc added a commit to chappjc/dcrdata that referenced this issue Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.1.2
  
Done
Development

Successfully merging this pull request may close these issues.

4 participants