Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace dummy text with English for Text truncation page #34936

Merged
merged 2 commits into from Sep 9, 2021

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Sep 9, 2021

PR is for: https://getbootstrap.com/docs/5.1/helpers/text-truncation/

Selected a short sentence from http://katyperryipsum.com/ where I think the other example text is from.

Selected a short sentence from http://katyperryipsum.com/ where I think the other example text is from.
ffoodd
ffoodd approved these changes Sep 9, 2021
Copy link
Member

@ffoodd ffoodd left a comment

Nice, thanks 🙂

@XhmikosR XhmikosR added this to In progress in v5.1.2 via automation Sep 9, 2021
@XhmikosR XhmikosR requested review from mdo and patrickhlauke Sep 9, 2021
@patrickhlauke
Copy link
Member

patrickhlauke commented Sep 9, 2021

Not so long ago I added lots of http://katyperryipsum.com/ dummy text everywhere, but in the end we re-replaced it with more descriptive generic text. Suggest perhaps doing the same, to keep to the same style - something quite boring and straightforward like "This text is quite long, and will be truncated once displayed."

@coliff
Copy link
Contributor Author

coliff commented Sep 9, 2021

thanks @patrickhlauke - that makes sense. 👍
Updated the PR - here's a quick preview:

image

v5.1.2 automation moved this from In progress to Ready to merge Sep 9, 2021
@XhmikosR XhmikosR merged commit f7c361f into twbs:main Sep 9, 2021
17 checks passed
v5.1.2 automation moved this from Ready to merge to Done Sep 9, 2021
@coliff coliff deleted the patch-2 branch Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.1.2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants