Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add align-self: center to buttons for improved rendering in flex containers" #35143

Merged
merged 1 commit into from Oct 9, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Oct 8, 2021

Reverts #34834. Fixes #35126.

/cc @ffoodd

@mdo mdo requested a review from as a code owner Oct 8, 2021
ffoodd
ffoodd approved these changes Oct 8, 2021
Copy link
Member

@ffoodd ffoodd left a comment

Sadly no other option IMHO, such things need to be handled on the parent I guess.

@mdo mdo changed the base branch from main to v513 Oct 8, 2021
@mdo mdo added this to In progress in v5.1.3 Oct 8, 2021
@XhmikosR XhmikosR merged commit 99d402b into v513 Oct 9, 2021
27 checks passed
@XhmikosR XhmikosR deleted the revert-34834-main branch Oct 9, 2021
v5.1.3 automation moved this from In progress to Done Oct 9, 2021
XhmikosR pushed a commit that referenced this issue Oct 9, 2021
@MakePixelsWork
Copy link

MakePixelsWork commented Oct 10, 2021

Does only 1 update, validate a full upgrade to a new version? This 1 thing is the only difference between 5.1.2 and 5.1.3.

@XhmikosR
Copy link
Member

XhmikosR commented Oct 10, 2021

Yeah, it was a regression and we wanted to get the fix out fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
4 participants