Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch dropdown.js #35991

Merged
merged 1 commit into from Apr 13, 2022
Merged

Patch dropdown.js #35991

merged 1 commit into from Apr 13, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Mar 10, 2022

Refactor after #35973

@GeoSot GeoSot requested a review from XhmikosR March 10, 2022 11:26
@GeoSot GeoSot requested a review from a team as a code owner March 10, 2022 11:26
@GeoSot GeoSot added this to In progress in v5.2.0 via automation Mar 10, 2022
mdo
mdo approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

v5.2.0 automation moved this from In progress to Reviewer approved Mar 10, 2022
@XhmikosR
Copy link
Member

Please don't merge this yet @mdo

@GeoSot GeoSot added the on-hold label Mar 11, 2022
@GeoSot GeoSot force-pushed the GeoSot-patch-2 branch 2 times, most recently from 71dac3e to df91145 Compare March 18, 2022 23:56
@GeoSot GeoSot removed the on-hold label Mar 18, 2022
@mdo
Copy link
Member

mdo commented Mar 25, 2022

@XhmikosR Okay to merge now?

@GeoSot GeoSot force-pushed the GeoSot-patch-2 branch 2 times, most recently from 5a0fe65 to 185560d Compare April 7, 2022 11:20
@GeoSot
Copy link
Member Author

GeoSot commented Apr 12, 2022

@louismaximepiton can you check it , too please?

louismaximepiton
louismaximepiton reviewed Apr 13, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me !

@GeoSot
Update dropdown.js
544c602 
minor refactoring
@mdo mdo merged commit cfd2f3f into main Apr 13, 2022
v5.2.0 automation moved this from Reviewer approved to Done Apr 13, 2022
@mdo mdo deleted the GeoSot-patch-2 branch April 13, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton left review comments

@mdo mdo mdo approved these changes

@XhmikosR XhmikosR Awaiting requested review from XhmikosR

Assignees
No one assigned
Labels
js refactoring v5
Projects
No open projects
v5.2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GeoSot @XhmikosR @mdo @louismaximepiton