Skip to content

v6 examples fixes#42432

Open
coliff wants to merge 1 commit into
twbs:v6-devfrom
coliff:dev/coliff/v6-examples-updates
Open

v6 examples fixes#42432
coliff wants to merge 1 commit into
twbs:v6-devfrom
coliff:dev/coliff/v6-examples-updates

Conversation

@coliff
Copy link
Copy Markdown
Contributor

@coliff coliff commented May 23, 2026

Description

  • Unify dark-theme styling and improve accessibility/layout across example pages.
  • Replaced various text-bg-dark/nav classes with bg-black, added fg-white and data-bs-theme="dark" where appropriate, and swapped a header div for a semantic <nav> with an aria-label in the album example.
  • Updated Chart.js to v4.5.1 and changed the dashboard search input type to "search"; adjusted border-right to border-end. Removed an outdated paragraph from the grid example and cleaned up hero/header text classes. Sidebars: made main scrollable with overflow helpers, applied bg-black and fg-white to the sidebar, simplified nav classes, added flex-fill to icon links, and updated sidebars.css to use -webkit-fill-available for height while removing explicit overflow rules.

Note: the SHA for the chart.js was changed to sha256 as that's the default JSDelivr offers. I think that's fine, but if you'd prefer sha384 as before I'll grab it from https://srihash.org/

Motivation & Context

fixes

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Unify dark-theme styling and improve accessibility/layout across example pages. Replaced various text-bg-dark/nav classes with bg-black, added fg-white and data-bs-theme="dark" where appropriate, and swapped a header div for a semantic <nav> with an aria-label in the album example. Updated Chart.js to v4.5.1 and changed the dashboard search input type to "search"; adjusted border-right to border-end. Removed an outdated paragraph from the grid example and cleaned up hero/header text classes. Sidebars: made main scrollable with overflow helpers, applied bg-black and fg-white to the sidebar, simplified nav classes, added flex-fill to icon links, and updated sidebars.css to use -webkit-fill-available for height while removing explicit overflow rules.
@coliff coliff requested a review from a team as a code owner May 23, 2026 03:45
Copilot AI review requested due to automatic review settings May 23, 2026 03:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates several Bootstrap example pages to align styling with newer theme utilities (e.g., data-bs-theme="dark", bg-black/fg-white), adjusts some layout/overflow handling, and bumps a third-party CDN dependency.

Changes:

  • Move some layout/overflow behavior from CSS into utility classes in the sidebars example.
  • Standardize “dark” styling across examples via data-bs-theme="dark" and updated foreground/background classes.
  • Update Chart.js CDN version + SRI, and make a few semantic/accessibility tweaks (e.g., <nav>, type="search", logical borders).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
site/src/assets/examples/sidebars/sidebars.css Removes main sizing/overflow rules to rely more on page-level utilities.
site/src/assets/examples/sidebars/index.astro Adds utility classes for sizing/overflow and updates dark theme styling + nav markup.
site/src/assets/examples/navbar-fixed/index.astro Updates navbar dark styling to use data-bs-theme="dark" + bg-black.
site/src/assets/examples/heroes/index.astro Adjusts dark hero styling and typography classes.
site/src/assets/examples/headers/index.astro Tweaks link text color classes within header examples.
site/src/assets/examples/grid/index.astro Removes an explanatory paragraph from the containers section.
site/src/assets/examples/dashboard/index.astro Bumps Chart.js CDN version/SRI; minor markup improvements (search input type, logical border).
site/src/assets/examples/album/index.astro Improves semantics (<nav>), updates dark header styling, and adjusts heading colors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread site/src/assets/examples/sidebars/index.astro
Comment thread site/src/assets/examples/sidebars/index.astro
Comment thread site/src/assets/examples/sidebars/index.astro
Comment thread site/src/assets/examples/headers/index.astro
Comment thread site/src/assets/examples/dashboard/index.astro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants