v6 examples fixes#42432
Open
coliff wants to merge 1 commit into
Open
Conversation
Unify dark-theme styling and improve accessibility/layout across example pages. Replaced various text-bg-dark/nav classes with bg-black, added fg-white and data-bs-theme="dark" where appropriate, and swapped a header div for a semantic <nav> with an aria-label in the album example. Updated Chart.js to v4.5.1 and changed the dashboard search input type to "search"; adjusted border-right to border-end. Removed an outdated paragraph from the grid example and cleaned up hero/header text classes. Sidebars: made main scrollable with overflow helpers, applied bg-black and fg-white to the sidebar, simplified nav classes, added flex-fill to icon links, and updated sidebars.css to use -webkit-fill-available for height while removing explicit overflow rules.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates several Bootstrap example pages to align styling with newer theme utilities (e.g., data-bs-theme="dark", bg-black/fg-white), adjusts some layout/overflow handling, and bumps a third-party CDN dependency.
Changes:
- Move some layout/overflow behavior from CSS into utility classes in the sidebars example.
- Standardize “dark” styling across examples via
data-bs-theme="dark"and updated foreground/background classes. - Update Chart.js CDN version + SRI, and make a few semantic/accessibility tweaks (e.g.,
<nav>,type="search", logical borders).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/assets/examples/sidebars/sidebars.css | Removes main sizing/overflow rules to rely more on page-level utilities. |
| site/src/assets/examples/sidebars/index.astro | Adds utility classes for sizing/overflow and updates dark theme styling + nav markup. |
| site/src/assets/examples/navbar-fixed/index.astro | Updates navbar dark styling to use data-bs-theme="dark" + bg-black. |
| site/src/assets/examples/heroes/index.astro | Adjusts dark hero styling and typography classes. |
| site/src/assets/examples/headers/index.astro | Tweaks link text color classes within header examples. |
| site/src/assets/examples/grid/index.astro | Removes an explanatory paragraph from the containers section. |
| site/src/assets/examples/dashboard/index.astro | Bumps Chart.js CDN version/SRI; minor markup improvements (search input type, logical border). |
| site/src/assets/examples/album/index.astro | Improves semantics (<nav>), updates dark header styling, and adjusts heading colors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bg-black, addedfg-whiteanddata-bs-theme="dark"where appropriate, and swapped a header div for a semantic<nav>with anaria-labelin the album example.Note: the SHA for the chart.js was changed to sha256 as that's the default JSDelivr offers. I think that's fine, but if you'd prefer sha384 as before I'll grab it from https://srihash.org/
Motivation & Context
fixes
Type of changes
Checklist
npm run lint)Live previews
Related issues