Skip to content
This repository

Bootstrap 2.3 #6346

Merged
merged 2 commits into from about 1 year ago

10 participants

Mark Otto Yohn Faisal shahzad leeaston Merg1255 P T Jacob bUg. Court K robertosante
Mark Otto
Owner

Work-in-progress pull request for bug fixes and enhancements before our 3.0 release. Originally this was slated as 2.2.3, but since we added a feature, it gets the minor release.

Key changes

  • Updated makefile to use local dependencies for easier dev setup.
  • Added carousel indicators! Add the associated HTML and it automagically works.
  • Added new justified navigation example. This was previously an unlinked and unsupported example I snuck in back in October. Officially adding it via the 2.3 release.
  • Added sticky footer with fixed navbar example because folks seem to have trouble adapting the default example.
  • Added container option to tooltips. The default option is still insertAfter, but now you may specify where to insert tooltips (and by extension, popovers) with the optional container parameter.
  • Improved popovers now utilize max-width instead of width, have been widened from 240px to 280px, and will automatically hide the title if one has not been set via CSS :empty selector.
  • Improved tooltip alignment on edges with #6713.
  • Updated input groups to make them behave more like default form controls. Added display: inline-block;, increased margin-bottom, and added vertical-align: middle; to match <input> styles.
  • Improved accessibility for links in all components. After merging #6441, link hover states now apply to the :focus state as well. This goes for basic <a> tags, as well as buttons, navs, dropdowns, and more.
  • Added print utility classes to show and hide content between screen and print via CSS.
  • Upgraded to jQuery 1.9. No changes were needed, but we did upgrade the included jQuery file to the latest release.
  • Moved changelog to be within the repo instead of as a wiki page.
  • Added .horizontal-three-colors() gradient mixin (with example in the CSS tests file).
  • Added .text-left, .text-center, and .text-right utility classes for easy typographic alignment.
  • Added @ms-viewport so IE10 can use responsive CSS when in split-screen mode.
  • Tooltips now work with SVG.
  • Updated to latest HTML5 shiv with a new local copy (within the repo) instead of the outdated Google Code version.
  • Fixed z-index issues with navbar and carousel controls in the carousel example.
  • Added support for th elements within tbody for .table-rounded.
  • Removed target-dir from composer.json.
  • Updated Holder.js from v1.6 to v1.9.
  • Other miscellaneous CSS and docs bugfixes items.

Specifics

Get the full list by viewing the closed issues, or peeping the list of commits in this pull request.

<3

Yohn

please fix tooltip('toggle') as its currently broken and has been for a little while.. I submitted a pull - #6176 but its going towards master, I can send it to 2.3 if need be, or you guys can add it if thats easier..

thanks for the hard work guys! you guys are pounding stuff out tonight

Faisal shahzad

facing popover issues. please check and update. n really appreciate for your handwork guys.. :)

Yohn

I like the carousel indicators! one thing I noticed is that when we click on them it doesnt go to that image, it doesnt do anything actually.. also since this is a carousel milestone I'd recommend trying to fix #5747 where it doesnt pause the sliding when you hover over the carousel while its in the middle of sliding..

both of these can be seen in the current 2.3.0-wip docs in firefox

leeaston

Text input is double height in IE8.
Screen Shot 2012-12-20 at 11 36 54 AM

Yohn

@leeaston it looks fine for me.. please open a new issue if this is not 2.3.0 related

ie8

leeaston

Sorry about that, I was testing 3.

Merg1255

Could you add #6180 for 2.3?
Thanks

Mark Otto
Owner

For the curious out there, here's a screenshot of the new justified navigation example we're officially adding in 2.3. It was previously snuck into the codebase in early October, but I never finished it nor added it to the list until now.

bootstrap-example-justified-nav

leeaston

Nice one! Don't forget to eat and sleep...

P T

@mdo Great example page! We've actually already implemented such a case, as #6346 (comment), in our center. The link is http://umbra.nascom.nasa.gov/

Thanks for adding new features. :)

Jacob
Owner

@Yohn we added new data attributes to support the indicator clicking. it's in there now :)

bUg.

Resetting transition timer on carousel must be implement if next/prev or carousel-indicators clicked

Atm it can be seen when any control clicked, but next image shown within few ms after start one.

Mark Otto mdo referenced this pull request December 28, 2012
Closed

. #1730

Mark Otto mdo referenced this pull request January 14, 2013
Closed

Two Makefile improvements #6435

Court K

What about pagination dots on sliders?

robertosante

anything soon?

Mark Otto mdo referenced this pull request February 05, 2013
Closed

Print utility classes #6190

Jacob fat merged commit c4d47fb into from February 07, 2013
Jacob fat closed this February 07, 2013
Mark Otto mdo deleted the branch February 08, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 26 additions and 0 deletions. Show diff stats Hide diff stats

  1. 26  CHANGELOG.md
26  CHANGELOG.md
Source Rendered
... ...
@@ -1,3 +1,29 @@
  1
+## 2.3.0 (February 7, 2013)
  2
+
  3
+Minor release to add carousel indicators, improve tooltips, improve dev setup, and fix hella bugs.
  4
+
  5
+- **Repository changes:**
  6
+  - **Local instead of global dependencies** for our makefile and install process. Now getting started is way easier—just run `npm install`.
  7
+  - Upgraded to jQuery 1.9. No changes were needed, but we did upgrade the included jQuery file to the latest release.
  8
+  - Moved changelog to be within the repo instead of as a wiki page.
  9
+- **New and improved features:**
  10
+  - **Added carousel indicators!** Add the HTML and it automagically works.
  11
+  - **Added `container` option to tooltips.** The default option is still `insertAfter`, but now you may specify where to insert tooltips (and by extension, popovers) with the optional container parameter.
  12
+  - Improved popovers now utilize `max-width` instead of `width`, have been widened from 240px to 280px, and will automatically hide the title if one has not been set via CSS `:empty` selector.
  13
+  - Improved tooltip alignment on edges with [#6713](https://github.com/twitter/bootstrap/pull/6713).
  14
+  - **Improved accessibility for links in all components.** After merging [#6441](https://github.com/twitter/bootstrap/pull/6441), link hover states now apply to the `:focus` state as well. This goes for basic `<a>` tags, as well as buttons, navs, dropdowns, and more.
  15
+  - Added print utility classes to show and hide content between `screen` and `print` via CSS.
  16
+  - Updated input groups to make them behave more like default form controls. Added `display: inline-block;`, increased `margin-bottom`, and added `vertical-align: middle;`  to match `<input>` styles.
  17
+  - Added `.horizontal-three-colors()` gradient mixin (with example in the CSS tests file).
  18
+  - Added `.text-left`, `.text-center`, and `.text-right` utility classes for easy typographic alignment.
  19
+  - Added `@ms-viewport` so IE10 can use responsive CSS when in split-screen mode.
  20
+- **Docs changes:**
  21
+  - Added [new justified navigation example](https://f.cloud.github.com/assets/98681/25869/5e2f812c-4afa-11e2-9293-501cd689232d.png).
  22
+  - Added sticky footer with fixed navbar example.
  23
+
  24
+See more on the [2.3.0 pull request](https://github.com/twitter/bootstrap/pull/6346).
  25
+
  26
+
1 27
 ## 2.2.2 (December 8, 2012)
2 28
 
3 29
 Bugfix release addressing docs, CSS, and some JavaScript issues. Key changes include:
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.