Update html5shim/shiv to 3.6.1, use a CDN #6514

Closed
wants to merge 1 commit into from

3 participants

@semenko

This commit:

  • Switches html5shiv to a CloudFlare cdnjs (from Google Code, which sets a sad Cache-Control max-age of 3 minutes)
  • Makes html5shiv protocol-relative (not sure where Issue #1706 went)
  • Updates html5shiv from vpre3.6 to 3.6.1 which fixes a few minor bugs

New html5shiv home: https://github.com/aFarkas/html5shiv

Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>

@semenko semenko Update html5shim/shiv to 3.6.1, use a CDN
This commit:
 - Switches html5shiv to a CloudFlare cdnjs (from Google Code)
   [Google Code sets a Cache-Control max-age of 3 minutes :( ]
 - Makes html5shiv protocol-relative (not sure where Issue #1706 went)
 - Updates html5shiv from vpre3.6 to 3.6.1 which fixes a few minor bugs

New html5shiv home: https://github.com/aFarkas/html5shiv

Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
2b802d6
@mdo
Bootstrap member

What are the implications of this new URL and super short cache vs. Google Code? I've never heard of CloudFlare until today.

The protocol was restored because we were running into issues with IE hanging completely with it. I know IE7-8 will load CSS twice if used with protocol-less links, but I don't recall if we had the same problem with the shiv.

@semenko
  • Looks like the double-loading issue is only for stylesheets (per http://www.stevesouders.com/blog/2010/02/10/5a-missing-schema-double-download/ and running his example through http://www.webpagetest.org/)

  • I think the biggest implication is since the Google Code URL isn't a CDN (and probably isn't meant to be used like this) their cache TTL is 180 seconds, so IE 7 & 8 clients frequently have the shiv expire. It also doesn't support gzip. The CloudFlare CDN has a TTL of about a year and supports gzip, which should reduce load times.

I think it'd be useful to have (1) an updated shiv, (2) with a long TTL & gzip, (3) on a reliable CDN. This meets the first two, though not 100% convinced about the third.

@iki
@mdo
Bootstrap member

Opted to include it locally after reading @iki's comment. Updated and ready to go in #6346. Thanks folks!

@mdo mdo closed this Jan 14, 2013
@semenko semenko deleted the unknown repository branch Jan 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment