intervals created by setInterval remain uncleared when manually invoking next and or previous #6655

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@evadnoob

I've found that intervals are cleanly cleared when invoking next & previous, by always clearing existing intervals in "cycle" before setting up a new interval, the problems that result from multiple intervals go away:

Here's an example:

setInterval 24 bootstrap-carousel.js:44
setInterval 25 bootstrap-carousel.js:44
clearInterval 25 bootstrap-carousel.js:75
setInterval 26 bootstrap-carousel.js:44
setInterval 28 bootstrap-carousel.js:44
clearInterval 28 bootstrap-carousel.js:75
setInterval 29

In the above, the interval 24 was just created, but gets lost and not cleared.

rebuilt bootstrap using "make" Had to modify path to get it to build:
export PATH=/usr/local/share/npm/bin:$PATH:/Users/evadnoob/Projects/mtrxi/node_modules/uglify-js/bin
@Yohn

This comment has been minimized.

Show comment
Hide comment
@Yohn

Yohn Jan 21, 2013

Contributor

this seems like it should fix some of the bugs wth the carousel but I havent tested it yet.. I may be giving it a shot in a couple hours

Contributor

Yohn commented Jan 21, 2013

this seems like it should fix some of the bugs wth the carousel but I havent tested it yet.. I may be giving it a shot in a couple hours

@Yohn

This comment has been minimized.

Show comment
Hide comment
@Yohn

Yohn Jan 21, 2013

Contributor

you might also need to add a test file for this to be merged

Contributor

Yohn commented Jan 21, 2013

you might also need to add a test file for this to be merged

@fat

This comment has been minimized.

Show comment
Hide comment
@fat

fat Feb 6, 2013

Member

cool thanks, i just patched it myself – in the future please no semicolons or large comments – thanks!

Member

fat commented Feb 6, 2013

cool thanks, i just patched it myself – in the future please no semicolons or large comments – thanks!

@fat fat closed this Feb 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment