New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tooltip positioning class to be added before positioning #6703

Closed
wants to merge 1 commit into
base: 2.3.0-wip
from

Conversation

Projects
None yet
2 participants
@muan
Contributor

muan commented Jan 25, 2013

Tooltip will be positioned wrong when there are position-specific tooltip styles(.tooltip.right, .tooltip.right .tooltip-inner with styles that change the box-model size), because the offset is calculated before the position classes(right, top, bottom, left) were added.

As shown: http://jsbin.com/esuwuj/10/edit

Simply adding the position class before calculating offset solves this issue.

@fat

This comment has been minimized.

Show comment
Hide comment
@fat

fat Feb 6, 2013

Member

just merged a big branch which is supposed to fix a bunch of tooltip pos issues – give that a try, and if it's still a problem could you reopen with a unit test? thanks!!

Member

fat commented Feb 6, 2013

just merged a big branch which is supposed to fix a bunch of tooltip pos issues – give that a try, and if it's still a problem could you reopen with a unit test? thanks!!

@fat fat closed this Feb 6, 2013

@muan muan deleted the muan:2.3.0-wip branch Dec 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment