New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: apply position class before positioning #7327

Merged
merged 1 commit into from Jul 18, 2013

Conversation

Projects
None yet
2 participants
@muan
Contributor

muan commented Mar 19, 2013

A follow up on this request: #6703
This wasn't fixed with the big push and is still there now, so I wrote a test to go with it.
I haven't figured out a better way to test this, but this one does test things correctly. And also, again, the fix is simply moving a line up.
Another jsbin to illustrate the problem: http://jsbin.com/esuwuj/10/edit

Thanks!! Have a nice day!!!

@fat

This comment has been minimized.

Show comment
Hide comment
@fat

fat Jun 28, 2013

Member

could you please update this pull request to auto merge – it looks great, just can't auto merge. thanks!

Member

fat commented Jun 28, 2013

could you please update this pull request to auto merge – it looks great, just can't auto merge. thanks!

@muan

This comment has been minimized.

Show comment
Hide comment
@muan

muan Jun 28, 2013

Contributor

@fat Done! Let me know if anything else! ❤️

Contributor

muan commented Jun 28, 2013

@fat Done! Let me know if anything else! ❤️

@fat

This comment has been minimized.

Show comment
Hide comment
@fat

fat Jul 18, 2013

Member

thanks!

Member

fat commented Jul 18, 2013

thanks!

@fat fat merged commit 55fa1ac into twbs:3.0.0-wip Jul 18, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment