Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add offcanvas layout example based on bradfrost/this-is-responsive #7799

Merged
merged 10 commits into from Jun 20, 2013

Conversation

@trumbitta
Copy link
Contributor

commented May 6, 2013

This is #6565 redone as a standalone example.

@mdo pointed that this should have been an example from the start (#6565 (comment))
Later on, @fat pointed that the JS was going to be too much simple for a proper plugin (#6565 (comment))

The only thing is that the JS is still written as a plugin for ease of development, but it is placed in a comfy /docs/assets/js/examples/bootstrap-offcanvas.js
Also, don't miss the TODO: trumbitta@01d0cf2#L2R55

@trumbitta trumbitta referenced this pull request May 6, 2013
5 of 6 tasks complete
mdo and others added 9 commits May 7, 2013
* Overhaul the form control sizing section to only show sizing via grid columns as parents, not as classes on inputs
* Restore the inline-form option
* Restore the bottom margin on form controls and make them block level instead of inline-block
* More misc docs cleanup for forms
…to offcanvas-example
@trumbitta

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2013

Yeah, well. I don't like the outcome of this update using rebase experiment of mine.

Subsequent updates from upstream will be via a classic merge.

@boulox

This comment has been minimized.

Copy link
Contributor

commented May 11, 2013

Just my 2 cents idea but maybe create a simple bootstrap js plugin for css class helper like classie by @desandro https://github.com/desandro/classie. Then slide-push menu could be handle by css ...

@trumbitta

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2013

Actually this started as a bootstrap js plugin. See #6565

@boulox

This comment has been minimized.

Copy link
Contributor

commented May 11, 2013

I know and kinda agree with @fat on this one. That why i suggest a general small js plugin to handle add/remove css class in the html. it could even be used for other components/features.

Check this out maybe will be more explicit. https://github.com/codrops/Blueprint-SlidePushMenus

@trumbitta

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2013

Indeed that would be handy!
But still it doesn't cover all the future work on the javascript side (trumbitta@01d0cf2#L2R55)

@mdo mdo merged commit 7090eb0 into twbs:3.0.0-wip Jun 20, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@mdo

This comment has been minimized.

Copy link
Member

commented Jun 20, 2013

Nuked the plugin and twerked some stuff, and then merged it in. Thanks!

@ckluis

This comment has been minimized.

Copy link

commented Jul 30, 2013

@trumbitta - is there any chance someone familiar with this plugin will build an example page for the documentation that implements the off-canvas menu?

@fguillen

This comment has been minimized.

Copy link

commented Dec 13, 2013

@ckluis looks like this is an example page: http://getbootstrap.com/examples/offcanvas make the screen narrow to activate the effect.

@trumbitta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2013

@ckluis @fguillen yep, the pull request was merged and the example was added up there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.