Fix to support nested carousels #8449
Conversation
To allow usage of nested carousels, there is a need to constraint selectors to only first level of elements so children carousels will be left untouched by sliding of parent carousel. Related issues: twbs#4359 unable to put carousel inside carousel twbs#7734 Conflict on item divs using nested carousel PS: Sorry if I format anything in wrong way, this is my second pull request (first was failure twbs#8448).
|
There is absolutely no way we're supporting nested carousels. |
|
In short, @Deele, it sounds like an awful experience and I see it going bad more often than it going well. |
|
@mdo Could you give us "the long" answer? Because I can't see any document, style guide or any other documented reasoning, that this is awful experience. From my point of view, designers of pages should think about "good experience", and let them do mistakes for themselves. Bootstrap is a tool, and same as HTML allows to nest anything in any tag, bootstrap should allow the same, otherwise it is silly to make such a constraints. This should be universal tool. |
|
...Is there any use case at all for nested carousels? |
|
What @renekooi said. I can't think of a single good experience that could be had from nesting carousels.
Not a bad philosophy, but some mistakes can be prevented altogether 😄.
Yes, not quite, probably not, and also not quite:
Hope that helps <3. |
|
A very simple use case in 2 lines: A carousel composed by groups (each item is a group and we have n "group" entities). Is it a crazy idea ? What is "bad" here ? And how could we compare that as a div in an input ?? This use case is more and more required by the mobile devices experiences. |
|
If you can design and prototype a quality nested carousel, we'll reconsider. Until then, I'm still not convinced it's ever a good idea. I also don't see how this would be required by mobile devices. |
|
I find that this feature can come in handy when one needs to slide html content (some sort of pagination) and that content also has an image carousel inside. The project I'm currently working on needed nested carousels to paginate article/project lists. Also, each article/project can have a carousel on it's thumbnail. This is an example of what was needed: |
|
@Deele its a clean and great solution to my carousel problem. Thanks! |
|
@gribelu Making that one responsive and usable from UX point of view, would be a challenge. |
To allow usage of nested carousels, there is a need to constraint selectors to only first level of elements so children carousels will be left untouched by sliding of parent carousel.
Related issues:
#4359 unable to put carousel inside carousel
#7734 Conflict on item divs using nested carousel
Fix tested and working on:
PS: Sorry if I format anything in wrong way, this is my second pull request (first was failure #8448).