New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pull-right(left) important #8697

Merged
merged 1 commit into from Aug 5, 2013

Conversation

Projects
None yet
6 participants
@liuyl
Contributor

liuyl commented Jul 28, 2013

Here's a bug #8693, .pull-right is override by btn-toolbar btn-group's float:left.
I think it is reasonable to make pull-right and pull-left !important, because users expect it acts like that.

Also I notied @mdo write a TODO in navs.less

// Todo: consider making these utilities !important to avoid this bullshit
@zdroid

This comment has been minimized.

Show comment
Hide comment
@zdroid

zdroid Jul 28, 2013

Great thing.

zdroid commented Jul 28, 2013

Great thing.

@goto-bus-stop

This comment has been minimized.

Show comment
Hide comment

👍

@archanl

This comment has been minimized.

Show comment
Hide comment
@archanl

archanl Jul 31, 2013

Contributor

👍

Contributor

archanl commented Jul 31, 2013

👍

@mdo mdo merged commit efac0bf into twbs:3.0.0-wip Aug 5, 2013

1 check passed

default The Travis CI build passed
Details

@liuyl liuyl deleted the liuyl:pullright branch Aug 6, 2013

@windeye

This comment has been minimized.

Show comment
Hide comment

windeye commented Aug 17, 2013

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment