New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility (Section 508, WCAG) #9137

Closed
wants to merge 32 commits into
base: 3.0.0-wip
from

Conversation

Projects
None yet
7 participants
@ajb
Contributor

ajb commented Aug 6, 2013

This PR significantly improves Bootstrap's accessibility for users of assistive technology, such as screen readers. Some of the these changes add additional markup to the source examples, but we believe that the sacrifice in readability is worth achieving more widespread usage of accessibility best-practices.

What was done

  • Added lots of WAI-ARIA attributes
  • Added .sr-only helper class, that is only readable by screen readers (and invisible for all other users). This lets us - make progress bars and paginations accessible to screen reading users.
  • Advised users to always use label elements. For inline forms, they can hide them with .sr-only
  • Added 'Skip navigation' link
  • Added "Accessibility" section to getting-started.html.

What wasn't done

  • Contrast issues (#3572)
  • Tooltips (#8469)
  • Documentation re: usage of icons, since they now live in a separate repo

Major props to all that contributed: @bensheldon, @jasonlally, @criscristina, and @louh. Feel free to chime in, guys, if I've left anything out.

Show outdated Hide outdated components.html
Show outdated Hide outdated components.html
Show outdated Hide outdated components.html
Show outdated Hide outdated javascript.html
Show outdated Hide outdated less/scaffolding.less
Show outdated Hide outdated less/scaffolding.less
Show outdated Hide outdated less/scaffolding.less
Show outdated Hide outdated css.html
Show outdated Hide outdated getting-started.html
@ajb

This comment has been minimized.

Show comment
Hide comment
@ajb

ajb Aug 6, 2013

Contributor

Thanks so much for the quick review. I think I've touched on all your comments with these added commits.

Contributor

ajb commented Aug 6, 2013

Thanks so much for the quick review. I think I've touched on all your comments with these added commits.

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 7, 2013

Member

We've done a lot to the docs today—any chance you could peep this tonight or tomorrow and get it up to date so we can do an easy merge without having to deal with conflicts?

Member

mdo commented Aug 7, 2013

We've done a lot to the docs today—any chance you could peep this tonight or tomorrow and get it up to date so we can do an easy merge without having to deal with conflicts?

@ajb

This comment has been minimized.

Show comment
Hide comment
@ajb

ajb Aug 7, 2013

Contributor

Definitely, will do so tonight. Should just a matter of merging the upstream repo in and fixing conflicts, right?

Contributor

ajb commented Aug 7, 2013

Definitely, will do so tonight. Should just a matter of merging the upstream repo in and fixing conflicts, right?

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 7, 2013

Member

Thanks, and yup, that should be it.

Member

mdo commented Aug 7, 2013

Thanks, and yup, that should be it.

@ajb

This comment has been minimized.

Show comment
Hide comment
@ajb

ajb Aug 7, 2013

Contributor

Done, but not really sure what's up with the BrowserStack key and why tests are failing.

Contributor

ajb commented Aug 7, 2013

Done, but not really sure what's up with the BrowserStack key and why tests are failing.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 7, 2013

Member

That's expected; ignore it.

Member

cvrebert commented Aug 7, 2013

That's expected; ignore it.

@ajb

This comment has been minimized.

Show comment
Hide comment
@ajb

ajb Aug 7, 2013

Contributor

Awesome. Let me know if there's anything else!

Contributor

ajb commented Aug 7, 2013

Awesome. Let me know if there's anything else!

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 7, 2013

Member

I tried my hand at it, but failed and can't devote more time to it right now. Can you by chance rebase this @adamjacobbecker so we get it a single commit?

Member

mdo commented Aug 7, 2013

I tried my hand at it, but failed and can't devote more time to it right now. Can you by chance rebase this @adamjacobbecker so we get it a single commit?

@ajb

This comment has been minimized.

Show comment
Hide comment
@ajb

ajb Aug 7, 2013

Contributor

I think you might have put too much faith in a guy who committed a merge conflict earlier. Having some trouble with this... let me try again, and then I'll call in the cavalry...

Contributor

ajb commented Aug 7, 2013

I think you might have put too much faith in a guy who committed a merge conflict earlier. Having some trouble with this... let me try again, and then I'll call in the cavalry...

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 7, 2013

Member

@adamjacobbecker Hah, I know that feel :). I've never really tried before and but I'm so swamped I can't spend more time giving it another go. @cvrebert might have some guidance—he did one earlier. I was working from one of several guides I found whilst Googling.

Member

mdo commented Aug 7, 2013

@adamjacobbecker Hah, I know that feel :). I've never really tried before and but I'm so swamped I can't spend more time giving it another go. @cvrebert might have some guidance—he did one earlier. I was working from one of several guides I found whilst Googling.

@ajb

This comment has been minimized.

Show comment
Hide comment
@ajb

ajb Aug 7, 2013

Contributor

Might have it done. Just gotta verify that I didn't lose anything.

Contributor

ajb commented Aug 7, 2013

Might have it done. Just gotta verify that I didn't lose anything.

@ajb

This comment has been minimized.

Show comment
Hide comment
@ajb

ajb Aug 7, 2013

Contributor

Let me know how that looks.

Contributor

ajb commented Aug 7, 2013

Let me know how that looks.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 7, 2013

Member

@adamjacobbecker Er, nope, still a kajillion commits.

Member

cvrebert commented Aug 7, 2013

@adamjacobbecker Er, nope, still a kajillion commits.

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 7, 2013

Member

Result of my attempt: #9186
Please double-check it.

Member

cvrebert commented Aug 7, 2013

Result of my attempt: #9186
Please double-check it.

@mgifford

This comment has been minimized.

Show comment
Hide comment
@mgifford

mgifford Nov 11, 2013

So are these changes in 3.0.2?

mgifford commented Nov 11, 2013

So are these changes in 3.0.2?

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Nov 11, 2013

Member

@mgifford They're in v3.0.0+. Read the successor pull request's merge commit.

Member

cvrebert commented Nov 11, 2013

@mgifford They're in v3.0.0+. Read the successor pull request's merge commit.

@mgifford

This comment has been minimized.

Show comment
Hide comment
@mgifford

mgifford commented Nov 11, 2013

Thanks!

@cvrebert cvrebert referenced this pull request Feb 10, 2014

Merged

add .sr-only-focusable #12679

@twbs twbs locked and limited conversation to collaborators Sep 17, 2014

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.