"squash" & rebasing of #9137 #9186

Merged
merged 1 commit into from Aug 7, 2013

Conversation

Projects
None yet
5 participants
@cvrebert
Member

cvrebert commented Aug 7, 2013

My attempt at "squashing" (and I'm using air quotes here intentionally) #9137 into a single commit and rebasing against 3.0.0-wip HEAD.
Seems successful AFAICT.
/cc @adamjacobbecker et al. for QC

Improve accessibility (Section 508, WCAG)
This PR significantly improves Bootstrap's accessibility for users of assistive technology, such as screen readers. Some of the these changes add additional markup to the source examples, but we believe that the sacrifice in readability is worth achieving more widespread usage of accessibility best-practices.

What was done
- Added lots of [WAI-ARIA attributes](http://www.w3.org/WAI/intro/aria)
- Added `.sr-only` helper class, that is only readable by screen readers (and invisible for all other users). This lets us - make progress bars and paginations accessible to screen reading users.
- Advised users to always use label elements. For inline forms, they can hide them with `.sr-only`
- Added 'Skip navigation' link
- Added "Accessibility" section to getting-started.html.

What *wasn't* done
- Contrast issues (twbs#3572)
- Tooltips (twbs#8469)
- Documentation re: usage of icons, since they now live in a separate repo

Major props to all that contributed: @bensheldon, @jasonlally, @criscristina, and @louh. Feel free to chime in, guys, if I've left anything out.
@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Aug 7, 2013

Member

Main conflict was in the modals example. I think I sorted it out okay.

Member

cvrebert commented Aug 7, 2013

Main conflict was in the modals example. I think I sorted it out okay.

@mdo mdo merged commit a8d95d4 into 3.0.0-wip Aug 7, 2013

1 check passed

default The Travis CI build passed
Details

@mdo mdo deleted the accessibility branch Aug 7, 2013

@ajb

This comment has been minimized.

Show comment
Hide comment
@ajb

ajb Aug 7, 2013

Contributor

Thanks @cvrebert (and @mdo) -- I had only rebased, not squashed. This looks great.

Contributor

ajb commented Aug 7, 2013

Thanks @cvrebert (and @mdo) -- I had only rebased, not squashed. This looks great.

@brennanmceachran

This comment has been minimized.

Show comment
Hide comment
@brennanmceachran

brennanmceachran Aug 8, 2013

This is awesome! Thanks guys!

This is awesome! Thanks guys!

@mgifford

This comment has been minimized.

Show comment
Hide comment
@mgifford

mgifford Oct 18, 2013

Is this now officially part of Bootstrap? I'm just following a link and need some confirmation.

Is this now officially part of Bootstrap? I'm just following a link and need some confirmation.

This comment has been minimized.

Show comment
Hide comment
@ajb

ajb Oct 18, 2013

Contributor

yes.

Contributor

ajb replied Oct 18, 2013

yes.

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Oct 18, 2013

Member

@mgifford Yes. Note the "master" and "v3.0.0" indicators in the footer of the commit description box.

Member

cvrebert replied Oct 18, 2013

@mgifford Yes. Note the "master" and "v3.0.0" indicators in the footer of the commit description box.

This comment has been minimized.

Show comment
Hide comment
@mgifford

mgifford Oct 18, 2013

Thank! Fast response is appreciated..

Thank! Fast response is appreciated..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment