BS3: Navbar overhaul #9403

Merged
merged 5 commits into from Aug 13, 2013

Conversation

Projects
None yet
1 participant
@mdo
Member

mdo commented Aug 13, 2013

screen shot 2013-08-12 at 9 39 27 pm

This overhauls our navbars to address a few items:

  • Navbars are now responsive by default (fits better with mobile first approach)
  • Navbars now require .nav-header to group .navbar-brand and .navbar-toggle for proper mobile display in conjunction with the collapsed content.
  • Renamed .nav-collapse to .navbar-collapse for a more consistent naming convention.
  • Refactored dropdown menus to use the old 2.x approach (no longer absolutely positioned, but rather as navbar nav links). Fixes #8792.
  • Simplified examples in docs to only highlight content not displayed in the first navbar example.

It can add some heft to an otherwise lightweight navbar, but I think all these improvements help the component and make it more durable in the long run. Still needs some finessing, but it's close I think.

mdo added some commits Aug 13, 2013

Navbar refactor
* Now responsive by default (fits better with mobile-first approach)
* Requires `.nav-header` to group `.navbar-brand` and `.navbar-toggle`
for proper mobile display.
* Changed `.nav-collapse` to `.navbar-collapse`
* Simplified examples in docs
Merge branch '3.0.0-wip' into bs3_navbar_overhaul
Conflicts:
	components.html
	dist/css/bootstrap.min.css
@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Aug 13, 2013

Member

Also addresses #9303.

Member

mdo commented Aug 13, 2013

Also addresses #9303.

mdo added a commit that referenced this pull request Aug 13, 2013

@mdo mdo merged commit 9482a5f into 3.0.0-wip Aug 13, 2013

1 check failed

default The Travis CI build failed
Details

@mdo mdo deleted the bs3_navbar_overhaul branch Aug 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment