New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BS3: Drop the accordion for the panel (fixes #8648) #9404

Merged
merged 3 commits into from Aug 13, 2013

Conversation

Projects
None yet
7 participants
@mdo
Member

mdo commented Aug 13, 2013

The accordion turned out to be basically the same as the panel, only not as cool. So, I've extended the panel component to include a .panel-group and collapsible features.

  • Deletes the accordion.less file
  • Extends the panel to be collapsible with our JS plugin
  • Supports panel color variations

Here's how it looks now with all panel markup:

screen shot 2013-08-12 at 11 34 52 pm
screen shot 2013-08-12 at 11 35 18 pm

mdo added some commits Aug 13, 2013

Drop the accordion for the panel
* Deletes the accordion.less file
* Extends the panel to be collapsible with our JS plugin
* Supports panel color variations

@mdo mdo referenced this pull request Aug 13, 2013

Closed

Collapse and Panels #8648

mdo added a commit that referenced this pull request Aug 13, 2013

Merge pull request #9404 from twbs/bs3_drop_accordion_for_panel
BS3: Drop the accordion for the panel (fixes #8648)

@mdo mdo merged commit 729854f into 3.0.0-wip Aug 13, 2013

1 check passed

default The Travis CI build passed
Details

@mdo mdo deleted the bs3_drop_accordion_for_panel branch Aug 13, 2013

@trumbitta trumbitta referenced this pull request Aug 14, 2013

Merged

WIP: Bootstrap 3 #6342

120 of 126 tasks complete
@trose

This comment has been minimized.

Show comment
Hide comment
@trose

trose Aug 14, 2013

Can we get an example of this new functionality on the site?

trose commented Aug 14, 2013

Can we get an example of this new functionality on the site?

@ggam

This comment has been minimized.

Show comment
Hide comment
@Martinomagnifico

This comment has been minimized.

Show comment
Hide comment
@Martinomagnifico

Martinomagnifico Aug 14, 2013

Can we get less markup in the panel/accordion? Like the href="#collapseOne" and corresponding id="collapseOne"? When I make an accordion in a group, the a with class accordion-toggle will always target the first next collapse. So not every panel needs an ID in my opinion, or is that against ARIA guidelines or something?

Maybe it can be optional, and if the href/id are not there, the above situation will apply and it will always target the next collapse in the group.

Can we get less markup in the panel/accordion? Like the href="#collapseOne" and corresponding id="collapseOne"? When I make an accordion in a group, the a with class accordion-toggle will always target the first next collapse. So not every panel needs an ID in my opinion, or is that against ARIA guidelines or something?

Maybe it can be optional, and if the href/id are not there, the above situation will apply and it will always target the next collapse in the group.

@nebusoft

This comment has been minimized.

Show comment
Hide comment
@nebusoft

nebusoft Aug 19, 2013

The documentation needs to be updated to show the "panel-default" in the markup to get the default colors. Without panel-default, the background color on the panel-heading will not be set to the one shown in the example version in the documentation. Thanks for the changes thus far I'm enjoying bootstrap more and more every day :)

The documentation needs to be updated to show the "panel-default" in the markup to get the default colors. Without panel-default, the background color on the panel-heading will not be set to the one shown in the example version in the documentation. Thanks for the changes thus far I'm enjoying bootstrap more and more every day :)

@robertlb24

This comment has been minimized.

Show comment
Hide comment
@robertlb24

robertlb24 Aug 23, 2013

The docs contain the word 'accordion-group' only once, this should be 'panel-group' I think?
(http://getbootstrap.com/javascript/#collapse - options)

The docs contain the word 'accordion-group' only once, this should be 'panel-group' I think?
(http://getbootstrap.com/javascript/#collapse - options)

@saas786

This comment has been minimized.

Show comment
Hide comment
@saas786

saas786 Aug 25, 2013

Contributor

@robertlb24 if you think so, please send a pull request with proper fix reflecting your suggested bug.

Contributor

saas786 commented Aug 25, 2013

@robertlb24 if you think so, please send a pull request with proper fix reflecting your suggested bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment