Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use font-weight: 100 on retina screens #351

Merged
merged 2 commits into from Mar 1, 2014
Merged

Only use font-weight: 100 on retina screens #351

merged 2 commits into from Mar 1, 2014

Conversation

connors
Copy link
Collaborator

@connors connors commented Feb 28, 2014

Use media queries to only show font-weight: 100 on retina screens.

Fixes: #310

cc: @XhmikosR

@connors connors added the docs label Feb 28, 2014
@connors connors added this to the 2.0.1 milestone Feb 28, 2014
@XhmikosR
Copy link
Member

I'm afk, I can have a closer look tomorrow if you are not in a hurry :)

On a side note, we don't load font weight 300 for Roboto. Did you try 400? It should be enough I think.

@connors
Copy link
Collaborator Author

connors commented Mar 1, 2014

@XhmikosR So we don't use Roboto at font-weight: 300. Should we be worried about Roboto at all?

@XhmikosR
Copy link
Member

XhmikosR commented Mar 1, 2014

Duh, you are right!
Also the reason I can't see the problem on my machine is because "Adelle-sans" doesn't exist so it's using Arial. And Arial at 100 looks fine.

This makes my 100 addition useless. I'll revert that later.

I think this is ok then, though I can't really verify since the fallback font is being used (Arial).

@zlatanvasovic
Copy link
Contributor

:shipit:

connors added a commit that referenced this pull request Mar 1, 2014
Only use font-weight: 100 on retina screens
@connors connors merged commit f17a5a1 into master Mar 1, 2014
@connors connors deleted the font-weights branch March 1, 2014 18:09
This was referenced Mar 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font-weight: 100 is too hard to read on no-retina
3 participants