Use a sprite for device images #361

Merged
merged 1 commit into from Mar 1, 2014

Projects

None yet

3 participants

@connors
Member
connors commented Mar 1, 2014

This will ensure smooth transitions when switching between platforms. Unfortunately we don't save a huge amount on space. The sprite is ~250k.

Addresses #313.

@connors connors added the docs label Mar 1, 2014
@connors connors added this to the 2.0.1 milestone Mar 1, 2014
@connors
Member
connors commented Mar 1, 2014

Also, the old images were ~100k each. So overall it's a win. 👍

@mdo mdo merged commit 317e70b into master Mar 1, 2014
@mdo mdo deleted the device-sprite branch Mar 1, 2014
This was referenced Mar 1, 2014
@XhmikosR
Member
XhmikosR commented Mar 2, 2014

@connors: they weren't 100KB each, I had compressed them losslessly ;)

@XhmikosR
Member
XhmikosR commented Mar 2, 2014

@connors: BTW, with Firefox the sprite doesn't work on desktop since you used the non-standard background-position-x.

2014-03-02_13-53-53

I fixed it in b6680e0

@connors
Member
connors commented Mar 2, 2014

@XhmikosR Thanks dude!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment