Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Travis CI support. #394

Merged
merged 1 commit into from Mar 3, 2014
Merged

Add initial Travis CI support. #394

merged 1 commit into from Mar 3, 2014

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 3, 2014

/CC @connor @connors @cvrebert

PS. Not sure if fast_finish makes sense here, at least not at this point.

node_js:
- "0.10"
before_script:
- npm install -g grunt-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run npm install after this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No you don't really need to do that IIRC. I use it in https://github.com/mpc-hc/mpc-hc.org and works fine.

@cvrebert
Copy link
Contributor

cvrebert commented Mar 3, 2014

Assuming the initial Travis build goes okay, LGTM.

@cvrebert cvrebert added this to the 2.0.1 milestone Mar 3, 2014
@XhmikosR XhmikosR self-assigned this Mar 3, 2014
XhmikosR added a commit that referenced this pull request Mar 3, 2014
Add initial Travis CI support.
@XhmikosR XhmikosR merged commit d89f830 into master Mar 3, 2014
@XhmikosR XhmikosR deleted the travis-ci branch March 3, 2014 18:30
@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 3, 2014

@cvrebert: completed fine with a couple of nice errors in the validator :)

@cvrebert cvrebert mentioned this pull request Mar 3, 2014
@mdo mdo mentioned this pull request Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants