Add CSSLint and CSSComb support. #431

Merged
merged 6 commits into from Mar 7, 2014

Projects

None yet

3 participants

@XhmikosR
Member
XhmikosR commented Mar 5, 2014

Fixes #281.

/CC @cvrebert @connor @connors @mdo

Note that I left the csslint target out of tests on purpose since it fails due to #390. When that issue is fixed, we should add it in tests.

@XhmikosR XhmikosR added this to the 2.0.2 milestone Mar 5, 2014
@XhmikosR XhmikosR self-assigned this Mar 5, 2014
@mdo
Member
mdo commented Mar 5, 2014

I'm guessing by all the reordering that we have some property order changes to make to the source Sass files?

Also, is there a way in CSScomb (I haven't checked yet) to remove the spaces between values in the rgba() colors?

@XhmikosR
Member
XhmikosR commented Mar 5, 2014

We could change some stuff around in Sass files indeed.

For rgba() I can't find any info how to remove the spaces so far.

@XhmikosR
Member
XhmikosR commented Mar 7, 2014

/CC @connors: maybe you are up to changing the properties order in the Sass files after this is in 👼

@connors
Member
connors commented Mar 7, 2014

you know it. ❤️

@connors
Member
connors commented Mar 7, 2014

@XhmikosR Would you rather me go in and work on fixing the property order in this pull request? Or do you just wanna get this in and I get follow up?

@XhmikosR
Member
XhmikosR commented Mar 7, 2014

I think it will be better if we merged this separately. Did you review the rest of the changes? If you agree I'll merge this and you can work on the rest.

@connors
Member
connors commented Mar 7, 2014

👍

@XhmikosR XhmikosR merged commit 7db2da9 into master Mar 7, 2014
@XhmikosR XhmikosR deleted the csslint branch Mar 7, 2014
@connors connors referenced this pull request Mar 12, 2014
Closed

v2.0.2 ship list #484

@XhmikosR
Member

@connors: I don't suppose you wanted to use

&.visible {
  @include transform(translate3d(0, 0, 0) translateY(0));
}

Though translate3d should be enough here.

Member

Yeah, translate3d covers it. Is there a reason to use this rather than translateY(0)? I figured we only needed to override the Y value.

Member

Ah I just saw your original comment. I thought for sure that translateX/Y were hardware accelerated though. The animations are so much smoother that transitioning left or right values.

Member

OK so this patch was right after all :)

And yeah, not everything is hardware accelerated on iOS it seems.

Member

lol ok I should read everything before I post comments. See this comment on the issue you referenced:
jquery/jquery-mobile#1603 (comment)

It looks like translateX/Y is accerated afterall. That's why the issue was closed.

Member

OK so this should be posted in #495 :P

BTW, somewhere along the way it seems the mobile navbar broke for docs...

@connors connors referenced this pull request Apr 1, 2014
Merged

Property order #534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment