Fix fingerblaster to use new custom event objects #446

Merged
merged 1 commit into from Mar 12, 2014

Projects

None yet

4 participants

@fat
Member
fat commented Mar 7, 2014

fixes fingerblast for firefox @connors @connor

@XhmikosR XhmikosR added js docs labels Mar 7, 2014
@XhmikosR XhmikosR added this to the 2.0.2 milestone Mar 7, 2014
@XhmikosR
Member
XhmikosR commented Mar 7, 2014

You seem to have entered non breaking spaces :P

(see Travis build)

@XhmikosR
Member
XhmikosR commented Mar 7, 2014

BTW @fat is this patch supposed to fix the TypeError in fingerblast?

Cause I still get 10:04:12.491 TypeError: Argument 1 of Node.compareDocumentPosition is not an object. docs.min.js:10 when I right click on the device image in /components/#sliders. Or even if I try to slide the "Slide me" text with #442 applied too.

@fat
Member
fat commented Mar 7, 2014

nah this fixes custom events

@connor
Contributor
connor commented Mar 10, 2014

👍 some travis issues tho

@XhmikosR
Member

I went ahead and fixed the Travis build and rebased the PR, feel free to merge it @connors

@connors connors merged commit 40260da into master Mar 12, 2014

1 check passed

default The Travis CI build passed
Details
@connors connors deleted the fat-fix-fingerblaster branch Mar 12, 2014
@connors connors referenced this pull request Mar 12, 2014
Closed

v2.0.2 ship list #484

@XhmikosR
Member

@fat: this breaks IE10 I tried.

SCRIPT445: Object doesn't support this action 
fingerblast.js, line 234 character 7
var e = new MouseEvent(eventName, {
...
@XhmikosR XhmikosR referenced this pull request Mar 14, 2014
Merged

JS fixes #491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment