Use `textContent` when `innerText` is not available. #518

merged 1 commit into from Apr 1, 2014


None yet

2 participants


Firefox does not implement innerText so this led to another TypeError: data.title.innerText is undefined.

/CC @connors @fat

@XhmikosR XhmikosR added the js label Mar 27, 2014
@XhmikosR XhmikosR added this to the 2.0.2 milestone Mar 27, 2014
@XhmikosR XhmikosR self-assigned this Mar 27, 2014
connors commented Mar 28, 2014

I'm good as long as @connor and @fat don't see anything wrong.

@XhmikosR XhmikosR referenced this pull request Mar 29, 2014

JS fixes #491


Well, it works :D

Sure, we could use jQuery's text or something, but doesn't seem the core code's using jQuery so I went with this approach.

@XhmikosR XhmikosR Use `textContent` when `innerText` is not available.
Firefox does not implement `innerText` so this led to another `TypeError`.
@XhmikosR XhmikosR merged commit 62f5f9f into master Apr 1, 2014

1 check passed

default The Travis CI build passed
@XhmikosR XhmikosR deleted the innerText branch Apr 1, 2014
@connors connors referenced this pull request Apr 1, 2014

v2.0.2 ship list #484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment