Re-enable clean-css's advanced optimizations. #522

Merged
merged 1 commit into from Apr 1, 2014

Projects

None yet

2 participants

@XhmikosR
Member

The issue was fixed in v2.1.8.

/CC @connors: I don't see the issue anymore myself, but please confirm :)

@connors connors added the grunt label Apr 1, 2014
@connors connors added this to the 2.0.2 milestone Apr 1, 2014
@connors
Member
connors commented Apr 1, 2014

I pulled the branch down and run grunt. Unfortunately I'm still see the issue with bar-footer failing to receive bottom: 0.

Could I be running something that's out of date? I ran npm install just to make sure.

@XhmikosR
Member
XhmikosR commented Apr 1, 2014

You shouldn't need to run grunt. Just check-out this branch and do jekyll serve.

It's possible that in your "node_modules" folder you have an older clean-css version like 2.1.7.

@connors
Member
connors commented Apr 1, 2014

Word. It was looking fine when I originally pulled down the branch. It wasn't until I ran grunt that I noticed the bug again.

@XhmikosR
Member
XhmikosR commented Apr 1, 2014

So do you confirm everything is fine? I rebased the branch, just reset your local branch and remove the "node_modules" directory && npm install.

@connors
Member
connors commented Apr 1, 2014

Everything looks great. 🚢

@XhmikosR XhmikosR merged commit e5a8c6d into master Apr 1, 2014

1 check passed

default The Travis CI build passed
Details
@XhmikosR XhmikosR deleted the clean-css-skip-advanced branch Apr 1, 2014
@connors connors referenced this pull request Apr 1, 2014
Closed

v2.0.2 ship list #484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment