New UI (Create module options page from JSON) #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djacu
force-pushed
the
filter-options-page
branch
3 times, most recently
from
1e99e9c to
bf2c6b4
Compare
djacu
force-pushed
the
filter-options-page
branch
from
7d80f24 to
8f57f4c
Compare
… to click on a heading and have the content expand/collapse.
…apse all buttons.
… option headings.
… need to add DOM restructuring and CSS.
djacu
force-pushed
the
filter-options-page
branch
from
9de3a30 to
f44d92b
Compare
djacu
added a commit
that referenced
this pull request
Jan 31, 2023
* Initial options support (just a proof so far) * revert template changes for now * Fix options.md to be generated in time * Initial work on python kernel * Skip (for now) some of the github actions jobs * Fix task name * Add more python kernel options * Write everything up to build jupyterlab-new flake output * also include options.json file * move general options under jupyterlab namespace * Adding bash kernel options * is this yaml file better * yaml fix (i think) * adding a c kernel * add kernel.elm module * add kernel.nix module * add kernel.postgres module * add kernel.zsh module * add kernel.go module * add kernel.haskell module * add kernel.javascript module * add kernel.julia module * kernel.ocaml init * New UI (Add Blog page to docs site) (#398) * updated codeowners (#397) * add new blog page to docs site. * New UI (Update Examples) (#401) * fix general jupyterlab runtime packages * fix bash kernel module required packages. * fix haskell module * updated example kernels to use new module system * fix javascript module * fix julia module * fix python stable kernel * fix nix run for jupyter lab with kernels * fix jupyterlab example with all kernels. * cleanup examples so filter list is in one spot. * fix example names to us folder so it's kernel.minimal instead of kernel.example. make sure there is no overlap in the future. * New UI (Add R module) (#403) * fix general jupyterlab runtime packages * fix bash kernel module required packages. * fix haskell module * updated example kernels to use new module system * fix javascript module * fix julia module * fix python stable kernel * fix nix run for jupyter lab with kernels * fix jupyterlab example with all kernels. * cleanup examples so filter list is in one spot. * fix example names to us folder so it's kernel.minimal instead of kernel.example. make sure there is no overlap in the future. * add r module Signed-off-by: Rok Garbas <rok@garbas.si> Co-authored-by: Rok Garbas <rok@garbas.si> * New UI (Add Rust module) (#404) * fix general jupyterlab runtime packages * fix bash kernel module required packages. * fix haskell module * updated example kernels to use new module system * fix javascript module * fix julia module * fix python stable kernel * fix nix run for jupyter lab with kernels * fix jupyterlab example with all kernels. * cleanup examples so filter list is in one spot. * fix example names to us folder so it's kernel.minimal instead of kernel.example. make sure there is no overlap in the future. * add rust module Signed-off-by: Rok Garbas <rok@garbas.si> Co-authored-by: Rok Garbas <rok@garbas.si> * New UI (Add Scala module) (#406) * fix general jupyterlab runtime packages * fix bash kernel module required packages. * fix haskell module * updated example kernels to use new module system * fix javascript module * fix julia module * fix python stable kernel * fix nix run for jupyter lab with kernels * fix jupyterlab example with all kernels. * cleanup examples so filter list is in one spot. * fix example names to us folder so it's kernel.minimal instead of kernel.example. make sure there is no overlap in the future. * add scala module. Signed-off-by: Rok Garbas <rok@garbas.si> Co-authored-by: Rok Garbas <rok@garbas.si> * New UI (Add TypeScript module) (#407) * fix general jupyterlab runtime packages * fix bash kernel module required packages. * fix haskell module * updated example kernels to use new module system * fix javascript module * fix julia module * fix python stable kernel * fix nix run for jupyter lab with kernels * fix jupyterlab example with all kernels. * cleanup examples so filter list is in one spot. * fix example names to us folder so it's kernel.minimal instead of kernel.example. make sure there is no overlap in the future. * Add typescript module. Signed-off-by: Rok Garbas <rok@garbas.si> Co-authored-by: Rok Garbas <rok@garbas.si> * New UI (Finish OCaml module) (#408) * fix general jupyterlab runtime packages * fix bash kernel module required packages. * fix haskell module * updated example kernels to use new module system * fix javascript module * fix julia module * fix python stable kernel * fix nix run for jupyter lab with kernels * fix jupyterlab example with all kernels. * cleanup examples so filter list is in one spot. * fix example names to us folder so it's kernel.minimal instead of kernel.example. make sure there is no overlap in the future. * finish ocaml module * Fix ocaml option documentation styling. * Update flake.nix Signed-off-by: Rok Garbas <rok@garbas.si> Signed-off-by: Rok Garbas <rok@garbas.si> Co-authored-by: Rok Garbas <rok@garbas.si> * New UI (Community tab and Matrix links) (#400) * added community tab and matrix links * styling Co-authored-by: Rok Garbas <rok@garbas.si> * New UI (Create module options page from JSON) (#389) * remove markdown options from build * load options config from json * move options javascript to module file * switching from modules to script because modules were causing problems * nest child options under parent in json object * nest child options under parent in DOM inside divs * make options collapsible * make collapsible options animated and update styles * add icons, make options closer together, add hover * fix light/dark mode background color * add kernel icon to the left of each option at the 'kernel.<kernelName>' level * update expand/collapse icon on options page * added expand/collapse all button if option has children. * made math for calculating logo sizes better. * fixed font colors by using mkdocs material css variables. * fixed and documented the function that nests the json object. * putting in TODOs for future improvements. * added documentation for function that converts options json to markdown. * little note about why the json to markdown function is recursive. * added documentation for the function that added the options content to the DOM and the function that nests sub-options. * updated and added documentation to the functions that add the ability to click on a heading and have the content expand/collapse. * updated and added documentation to the function that adds expand/collapse all buttons. * updated and documented the function that adds the kernel icons to the option headings. * little optimizations in the option JS code * turned the options script into a module. * remove old options script * switched out javascript client code for python build time code. still need to add DOM restructuring and CSS. * switch to markdown-it-py for conversion to html b/c it complies with CommonMark spec. * added python function to nest options in dom. * styling the options so it degrades gracefully if JS is disabled * moved options JS file back out of modules * not using JS modules any more. breaks with mkdocs * moved nesting children in dom to python. no more FOUC * fixed some accessibility issues and logo sizes/positions * making nice tree view lines for nested options * redo layout, styling, and javascript for simplicity and maintainability * clean up and document options code. * setup page so it works without JS and initialize page if JS is enabled. * switched to using jQuery for animation. much smoother and cleaner. * break up options into sections under headers. Co-authored-by: Rok Garbas <rok@garbas.si> * uncomment ci.yml Signed-off-by: Rok Garbas <rok@garbas.si> * fix workflow. * fix example kernel names and associated tests * more ci workflow fixes. * redid poetry module. exposed requiredRuntimePackages. fixed several tests. * fix elm required packages * fix error: attribute 'nixpkgs' missing from config when building docs * temp. remove julia and haskell from CI till they can be fixed. * trying to fix workflow. * trying to fix workflow again. * trying to fix workflow again x2. * fix nesting of json children. * hide edit page button for Options. * remove '(New)' from Options tab. * fixed haskell kernel module. * add haskell and julia tests back in * adding info to julia test for debugging. * Revert "adding info to julia test for debugging." This reverts commit bed0772. * bandaid for Julia CI. * organized the docs folder. * fix template and its test. * trying to fix github API rate limit exceeded. * Revert "trying to fix github API rate limit exceeded." This reverts commit 66678a2. * Fix examples and defaults by using literalExpression and defaultText. * update json encoder so it handles lists of objects * updated the kernel module options. * fixed groups and main description for poetry modules * add requiredRuntimePackages to kernelArgs in kernel module. * fix haskel module. * fix rust module * fix go module. * cleaned up all the modules defaults, examples, and descriptions so it looks nice. * fixed requiredRuntimePackages * updated flake template welcome text. * switch occurences of jupyterWith to jupyenv except in the template and CI (need to wait for repo name change first). * moving template kernels nix file to top level. don't need folder any more. * add temp options content html file so 'mkdocs serve' works properly * add an admonition for using the julia kernel for when things go wrong. * updated how-to * removed the tutorials and moved some of the content to how to. updated the how to. fixed broken links. * moved options higher in the sidebar list. * move styling and js out of home.html and into their own files. * added dart sass * added sass to style the home page instead of JS and CSS * replace home page logos with svg versions. fix planet orbit alignments. * switched to index by 0 * fix options kernel logos * fix options styling to use classes. nest logos in div so they can be positioned nicely. * clean up options css. * add ignoreCollisions to all poetry based kernels. * fixed example python science kernel * fixed example python science kernel tests * really fix the python science example kernel. * add anchors next to the option buttons. make the page option the option and scroll to it on page load. * switched occurances of jupyterwith to jupyenv. left the flake template url path until the repo is renamed * replace unicode angle brackets with ascii versions * fix expand/collapse all buttons. * making anchor links work better. --------- Signed-off-by: Rok Garbas <rok@garbas.si> Co-authored-by: Dan Baker <daniel.n.baker@gmail.com> Co-authored-by: Daniel Baker <daniel.baker@tweag.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.