You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In theory, prebuilt_dependencies should be deprecated and thus unnecessary, but going through the usage, non-trivial parts of rules_haskell still depend on it:
HaskellHaddock passes it as argument to haddock_wrapper.sh. Does that mean haskell_import is not yet supported by the haddock generator, @mrkkrp?
Concerning haskell_import, I’m confused as to which version should actually be used. We have the new one in import.bzl, but it’s not exported as far as I can see. But since haskell_import should be the replacement for prebuilt_dependencies, we should define which one to use (or throw one out). cc @regnat
The text was updated successfully, but these errors were encountered:
Okay, when going through the code with Théophane, we found that prebuilt_dependencies actually has two uses:
attribute in all haskell rules
internal mechanism to pass prebuilt stuff, also for haskell_import
Since we already deprecated the user-facing part, we can remove the attribute, but keep the internal usage for now.
The next step would be to finish new-style haskell_import and get rid of all that internal wiring and the HaskellPrebuiltPackageInfo provider as well, but that’s out of scope for this issue.
The user-facing parts of `prebuilt_dependencies` have been superseeded
by `haskell_import`. Changes all examples to the new API and removes
the attribute, which has been deprecated since 0.6.
Fixes#504Fixes#540
The user-facing parts of `prebuilt_dependencies` have been superseeded
by `haskell_import`. Changes all examples to the new API and removes
the attribute, which has been deprecated since 0.6.
Fixes#504Fixes#540
In theory,
prebuilt_dependencies
should be deprecated and thus unnecessary, but going through the usage, non-trivial parts ofrules_haskell
still depend on it:HaskellHaddock
passes it as argument tohaddock_wrapper.sh
. Does that meanhaskell_import
is not yet supported by the haddock generator, @mrkkrp?rules_haskell/haskell/haddock.bzl
Lines 117 to 124 in 2b163f7
HaskellProtoc
uses it internallyrules_haskell/haskell/protobuf.bzl
Line 148 in 2b163f7
Concerning
haskell_import
, I’m confused as to which version should actually be used. We have the new one inimport.bzl
, but it’s not exported as far as I can see. But sincehaskell_import
should be the replacement forprebuilt_dependencies
, we should define which one to use (or throw one out). cc @regnatThe text was updated successfully, but these errors were encountered: