Do not -package transitive dependencies. #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it would be nice to have a set of negative tests of things that shouldn't work. We have some of those in rules_scala. So, you could have a test that the |
|
I'll check it out. Anywhere in particular I should look? |
|
check out: https://github.com/bazelbuild/rules_scala/blob/master/test_rules_scala.sh see all the We have a significant number of negative tests. |
mboes
approved these changes
Jan 6, 2018
|
CI is red on this branch. Could you have a look? |
Fuuzetsu
force-pushed
the
non-transitive-package
branch
from
fbc9479
to
0970c6f
Compare
If A depends on B and B depends on C, previously A could import directly from C without listing C in dependencies. It should not. Fixes #72.
Fuuzetsu
force-pushed
the
non-transitive-package
branch
from
0970c6f
to
3a85931
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If A depends on B and B depends on C, previously A could import
directly from C without listing C in dependencies. It should not.
Fixes #72.