Some Changes #24

Closed
wants to merge 8 commits into
from

Projects

None yet

3 participants

@infusion

Hi,

this pull request includes some changes to tween. I've simplified some expressions, added requestAnimationFrame and some minor changes.

Robert

@sole
Member
sole commented Dec 20, 2011

Hello, Robert!

Thanks for the patch. I'm having a bit of a hectic schedule lately and haven't had time to test/integrate this yet... I'll look at that as soon as I can, ok? :-)

Good work, by the way!

@mrdoob mrdoob closed this in e79347e Apr 3, 2012
@mrdoob
mrdoob commented Apr 3, 2012

Thanks! :)

@infusion
infusion commented Apr 3, 2012

Thanks for implementing the formula simplification. What about the other changes? Three.js got RequestAnimationFrame long before and also the local variable fixes should be fixed as well.

@mrdoob
mrdoob commented Apr 3, 2012

I'm considering removing the autoStart feature...
And the local variable fixes have been fixed by another pull request I think.

@sole
Member
sole commented Apr 3, 2012

I must apologise for not having merged this before. It was totally on my TODO list but... well, sorry!

Regarding removing autostart I agree it makes thing slightly complicated but I'd like to reference the issue where that functionality was introduced: #18

so we can consider both points of view :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment