Support for multiple values in the Phone field

[Bonapara]

Current Behavior

Currently, our system allows for only a single phone number to be added to a phone field. However, individuals often have multiple phone numbers, which may vary significantly. To accommodate this, we need a more flexible solution than adding multiple fields like "Phone 2, Phone 3, Phone X."

Desired Behavior

We should adapt our data structure to allow for multiple phone numbers in a single phone field, similar to our previous enhancement for multiple links. The proposed data structure is as follows:

phones {
  primaryPhone {
    number
    countryCode
  }
  additionalPhones 
}

This structure will enable us to store a primary phone and an array of additional phone numbers. The implementation should mirror the approach used in the multiple links field update.

Figma

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=28562-74913&t=hrDkyWQ3cs5iGjno-11

[charlesBochet]

Discuss with @ijreilly before tackling this one

[gitstart-app]

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6260

[ijreilly]

Some technical hints here -

Currently we have fields of type Phone that can be used for customized fields, and a standard field of type Text called "phone" on the standard object "person". We need to migrate both the Phone type custom fields and the phone standard field to the new Phones type.

I would recommend first tackling #6261 to get familiar with the issue

1. (PR 1) Introduce new “Phones” composite field type (similar to “Links”)
   After this step is merged it is no longer possible to create custom field with the “old” phone type, but they are still part of the created standard fields, are still displaying correctly etc.

• Create the new field type (FieldMetadataType.Phones)
• Handle field display (inspiration: LinksFieldDisplay)
• Handle field update (inspiration: LinksFieldInput). inputted value (ex: +33601020304) should be stored as the phone number while the countryCode should be inferred from input using the lib react-phone-number-input that we use for the current phone field input.
• Prevent creation of new fields with "Phone" type (example PR)
• To test: reset of db, creation of a new workspace, creation and filling of phones...

2. (PR 2) Update standard fields of type "Phone" to the new type
   After this step is merged, newly created workspaces will directly benefit from the new type, while the existing workspaces need to have their migration to the new type done before they can have their metadata synchronized again; so this should only be merged and deployed when we are ready to do the migrations (step 3).

• Update standard objects' standard phone fields of type Phone. I think you only need to update person's email field here, updating type from Text to Phones. (example PR)

3. (PR 2 - same as step 2) Write script to replace "phone" fields with "phones" fields, handling the data migration
   After this step is merged, we can run the command on all active workspaces to migrate their data (twenty team will take care of running the command).

• Example migration script - full PR. In addition here you need to migrate the standard phone field on person from type Text to Phones.
• We want to migrate the current value of phone field to the new fields' phones.primaryPhone. countryCode has to be backfilled.
• This type of command is now usually added to a group of commands that need to be run to allow for the upgrade to a new version of twenty, eg upgrade:0-23. You can probably add this to a future 0.24 command as this will not be ready by the time we release 0.23. For instance for 0.23 the command to run is yarn command:prod upgrade-0.23
• To test: migration of data, sync-metadata on migrated workspaces (command yarn command:prod workspace:sync-metadata), running command multiple times of the same workspace that initially required a migration, running command simulating errors to ensure rollback is working correctly

[FelixMalfait]

Closing the issue as the PR was merged. @gitstart-twenty please create a new issue if they are any followups to do! Thanks!