Rtrimmed truncated value. #61

Merged
merged 1 commit into from Dec 15, 2012

Conversation

Projects
None yet
4 participants
Contributor

umpirsky commented Jun 27, 2012

Trimmed trailing spaces.

Example:

before: Lorem ipsum ...
after: Lorem ipsum...

Contributor

umpirsky commented Jun 30, 2012

@fabpot Ping.

This behavior looks weird. At least, I don't expect it...
Can it be triggered using a parameter ? Also can you provide some tests ?

Contributor

umpirsky commented Jul 2, 2012

Isn't it wrong to have white space before ...?

Yes it is right. Can you provide test ?

Contributor

umpirsky commented Jul 2, 2012

Then we don't need tests, simply reject my PR. I will implement custom extension for this because I find text Lorem ipsum ... invalid.

Sorry for the misunderstanding. I think your PR is valid. It just deserves a unit test ;)

Contributor

umpirsky commented Jul 2, 2012

But there is no test for any of extensions?

Well, too bad.
Whatever, I am +1 for this PR

Contributor

umpirsky commented Jul 2, 2012

I would be happy to contribute tests. I can't promise, but if I find some time, I will fix a PR.

👍 for this one.

@fabpot fabpot added a commit that referenced this pull request Dec 15, 2012

@fabpot fabpot merged branch umpirsky/truncate-patch (PR #61)
This PR was merged into the master branch.

Commits
-------

d67bc7e Rtrimmed truncated value.

Discussion
----------

Rtrimmed truncated value.

Trimmed trailing spaces.

Example:

before: `Lorem ipsum ...`
after:    `Lorem ipsum...`

---------------------------------------------------------------------------

by umpirsky at 2012-06-30T11:06:49Z

@fabpot Ping.

---------------------------------------------------------------------------

by michelsalib at 2012-07-01T22:45:30Z

This behavior looks weird. At least, I don't expect it...
Can it be triggered using a parameter ? Also can you provide some tests ?

---------------------------------------------------------------------------

by umpirsky at 2012-07-02T06:15:16Z

Isn't it wrong to have white space before ...?

---------------------------------------------------------------------------

by michelsalib at 2012-07-02T06:31:22Z

Yes it is right. Can you provide test ?

---------------------------------------------------------------------------

by umpirsky at 2012-07-02T14:52:01Z

Then we don't need tests, simply reject my PR. I will implement custom extension for this because I find text `Lorem ipsum ...` invalid.

---------------------------------------------------------------------------

by michelsalib at 2012-07-02T14:54:09Z

Sorry for the misunderstanding. I think your PR is valid. It just deserves a unit test ;)

---------------------------------------------------------------------------

by umpirsky at 2012-07-02T15:48:02Z

But there is no test for any of extensions?

---------------------------------------------------------------------------

by michelsalib at 2012-07-02T16:07:11Z

Well, too bad.
Whatever, I am +1 for this PR

---------------------------------------------------------------------------

by umpirsky at 2012-07-02T17:15:26Z

I would be happy to contribute tests. I can't promise, but if I find some time, I will fix a PR.

---------------------------------------------------------------------------

by pjedrzejewski at 2012-12-03T11:53:29Z

👍  for this one.
d1990ff

fabpot merged commit d67bc7e into twigphp:master Dec 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment