From fa767a15ad64416a097502ab8dcf8051103beef5 Mon Sep 17 00:00:00 2001 From: sarah-eit Date: Fri, 14 Jun 2024 16:44:52 +0200 Subject: [PATCH] fix typing and charset and description --- src/Extension/CoreExtension.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Extension/CoreExtension.php b/src/Extension/CoreExtension.php index 212dc13222..e3c7d8774b 100644 --- a/src/Extension/CoreExtension.php +++ b/src/Extension/CoreExtension.php @@ -221,7 +221,7 @@ public function getFilters(): array // string/array filters new TwigFilter('reverse', [self::class, 'reverse'], ['needs_charset' => true]), - new TwigFilter('shuffle', [self::class, 'shuffleFilter'], ['needs_environment' => true]), + new TwigFilter('shuffle', [self::class, 'shuffle'], ['needs_charset' => true]), new TwigFilter('length', [self::class, 'length'], ['needs_charset' => true]), new TwigFilter('slice', [self::class, 'slice'], ['needs_charset' => true]), new TwigFilter('first', [self::class, 'first'], ['needs_charset' => true]), @@ -897,16 +897,14 @@ public static function reverse(string $charset, $item, $preserveKeys = false) } /** - * Shuffle an array, a \Traversable instance, or a string. + * Shuffles an array, a \Traversable instance, or a string. * The function does not preserve keys. * * @internal */ - public static function shuffleFilter(Environment $env, mixed $item): mixed + public static function shuffle(string $charset, array|\Traversable|string|null $item): mixed { if (\is_string($item)) { - $charset = $env->getCharset(); - if ('UTF-8' !== $charset) { $item = self::convertEncoding($item, 'UTF-8', $charset); }