Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runtime deprecation that prevent smooth update #2874

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Contributor

nicolas-grekas commented Mar 10, 2019

This deprecation is already triggered when a class that implements InitRuntimeInterface is loaded.
This runtime deprecation prevents creating a continuous upgrade path.

@fabpot

This comment has been minimized.

Copy link
Contributor

fabpot commented Mar 10, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 8f9fe27 into twigphp:2.x Mar 10, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

fabpot added a commit that referenced this pull request Mar 10, 2019

minor #2874 Remove runtime deprecation that prevent smooth update (ni…
…colas-grekas)

This PR was merged into the 2.x branch.

Discussion
----------

Remove runtime deprecation that prevent smooth update

This deprecation is already triggered when a class that implements `InitRuntimeInterface` is loaded.
This runtime deprecation prevents creating a continuous upgrade path.

Commits
-------

8f9fe27 Remove runtime deprecation that prevent smooth update

nicolas-grekas added a commit to symfony/symfony that referenced this pull request Mar 10, 2019

bug #30506 [TwigBridge] remove deprecation triggered when using Twig …
…2.7 (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] remove deprecation triggered when using Twig 2.7

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Needs twigphp/Twig#2874
Should make the CI green on 3.4.

Commits
-------

c17a5b2 [TwigBridge] remove deprecation triggered when using Twig 2.7

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-deprec branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.